Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): job handlers #2572

Merged
merged 3 commits into from
May 26, 2023
Merged

refactor(server): job handlers #2572

merged 3 commits into from
May 26, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented May 26, 2023

  • Remove ASSET_UPLOAD job
  • Add new onDone call when a job finishes and returns true.
  • Merge two exif jobs into one (for both video and photo)
  • Removed all try/catch from jobs and replaced with a single try catch in the caller
  • Move all end-of-queue-queuing to JobService#onDone
  • Replaced all job interfaces with asset/user to now use { id: string } and lookup the record in the handler
  • Removed AssetCore and moved the index queuing to onDone

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) May 26, 2023 6:39pm

Base automatically changed from refactor/bull-jobs to main May 26, 2023 12:52
@jrasm91 jrasm91 force-pushed the refactor/job-handlers branch from 4805fc0 to 62c74b3 Compare May 26, 2023 13:42
@alextran1502 alextran1502 merged commit 1c2d83e into main May 26, 2023
@alextran1502 alextran1502 deleted the refactor/job-handlers branch May 26, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants