feat(mobile): partner sharing #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Tested this in profile mode if that might matter. Ran into some syncing issues, leading to an empty partner page. Logs showed _linkWithExistingFromDb encountered asset only in DB
On the main timeline there was also an issue with assets showing up twice on regular load and even 3 or 4 times when I manually refresh (see video below). Logs for regular load:
#0 Load assets: 243ms
#1 Upserted 59 assets into the DB
#2: Upserted 1 assets into the DB
#3: Upserted 59 assets into the DB
2023-05-24.09-20-12.mp4
alextran1502
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: server version and app version must match for the partner sharing to work in the app
implements partner sharing functionality in the app.
userIdparameter toAssetSearchDtoforgetAllAssetsroute on the serverUserclass with partner attributesETagdatabase entity to store different eTags for different requests (so fargetAllAssetsfor multiple users) to cache these large requestssome screenshots below: