feature(mobile): no longer wait for background backup in settings #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fyfrey
commented
Mar 12, 2023
fyfrey
commented
- migrate all Hive boxes required for the backup process to Isar
- the Isar database can be safely used from multiple isolates -> allow main (UI) isolate to be active while background backup is running, merge backup album changes if needed
- foreground backup and background backup still wait on each other via the locking mechanism (makes no sense / produces errors if both would run concurrently)
- does not alter the backup logic
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
martyfuhry
reviewed
Mar 14, 2023
Nothing in particular. Just use the app I guess |
fyfrey
force-pushed
the
dev/migrate-backup-hive-to-isar
branch
2 times, most recently
from
06fadd6 to
2766015
Compare
added 2 commits
March 17, 2023 22:12
migrate all Hive boxes required for the backup process to Isar
fyfrey
force-pushed
the
dev/migrate-backup-hive-to-isar
branch
from
2766015 to
abd6fa9
Compare
alextran1502
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.