feat(web): Context menu scrolls on small devices #15367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matitalatina
force-pushed
the
scroll-on-small-devices
branch
from
bdcc69d to
182c9d3
Compare
matitalatina
commented
Jan 15, 2025
| class:max-h-0={!isVisible} | ||
| class="flex flex-col transition-all duration-[250ms] ease-in-out outline-none" | ||
| class="{isVisible | ||
| ? 'max-h-screen max-h-svh' |
There was a problem hiding this comment.
I put both 100vh and 100svh for retro compatibility.
I preferred svh instead of dvh because it should be more stable reading the CSS standard.
The sizes of the dynamic viewport-percentage units are not stable even while the viewport itself is unchanged. Using these units can cause content to resize e.g. while the user scrolls the page. Depending on usage, this can be disturbing to the user and/or costly in terms of performance.
jrasm91
approved these changes
Jan 15, 2025
matitalatina
force-pushed
the
scroll-on-small-devices
branch
from
182c9d3 to
faf3f49
Compare
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
Context menu scrolls on small devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context menu can scroll on small devices
Screenshots
This is before the change
This is after the change
How I tested
Tested on: