feat(server): sort assets randomly from the API 'api/search/metadata' endpoint by including 'order': 'rand' in the API call. #12741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwalbe
changed the title
jrasm91
reviewed
Sep 17, 2024
mertalev
reviewed
Sep 17, 2024
jrasm91
force-pushed
the
api-with-random
branch
from
bc6a4cd to
0246c41
Compare
danieldietzler
approved these changes
Sep 23, 2024
jrasm91
force-pushed
the
api-with-random
branch
from
0246c41 to
8d9f49f
Compare
jrasm91
approved these changes
Sep 23, 2024
mertalev
reviewed
Sep 23, 2024
| builder.orderBy('asset.fileCreatedAt', options.orderDirection ?? 'DESC'); | ||
|
|
||
| if (options.random) { | ||
| mode = PaginationMode.LIMIT_OFFSET; |
There was a problem hiding this comment.
I don't think limit/offset is safe here because there are possible joins with one-to-many or many-to-many relations.
There was a problem hiding this comment.
A thought: you could make a separate /search/random endpoint that takes the same options as the smart search endpoint but without the query field.
There was a problem hiding this comment.
I see. The other pagination throws an error I did not know how to fix. If you have time can you take a look?
There was a problem hiding this comment.
Nevermind, I think I figured it out.
jrasm91
force-pushed
the
api-with-random
branch
2 times, most recently
from
fec9f98 to
af077b1
Compare
jrasm91
force-pushed
the
api-with-random
branch
from
af077b1 to
b0b2012
Compare
mertalev
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
GET /api/assets/randomis now deprecated in favor ofPOST /api/search/randomGoal is to simplify getting random photos for a kiosk. The new API call works as such: