Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the navigation event from the explainer #260

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Conversation

toji
Copy link
Member

@toji toji commented Jul 21, 2017

Requested by @NellWaliczek. This is for the sake of clarifying things
for TAG review if we don’t get a better solution in place before they
look at the explainer, since we know this ISN’T the right way to handle
this. Ideally we’ll put it back in with #256 or a similar PR.

Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @toji ! In the same vein of cleaning up of non-finalized topics being addressed in a separate PR, can we remove the section on "Presenting automatically when the user interacts with the headset"?

@NellWaliczek
Copy link
Member

I imagine @ddorwin would agree since he said something similar in #248 ;)

@toji
Copy link
Member Author

toji commented Jul 21, 2017

Done!

Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

toji added 2 commits July 21, 2017 20:47
Requested by @NellWaliczek. This is for the sake of clarifying things
for TAG review if we don’t get a better solution in place before they
look at the explainer, since we know this ISN’T the right way to handle
this. Ideally we’ll put it back in with #256 or a similar PR.
Same reason as previous commit
@toji toji force-pushed the remove-navigate branch from 33e0007 to f396585 Compare July 22, 2017 03:49
@toji toji merged commit 04fc7dc into master Jul 22, 2017
@toji toji deleted the remove-navigate branch July 22, 2017 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants