Changed createFrameOfReference -> requestFrameOfReference #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings it inline with all of our other asynchronous calls which use the “request” verbiage. “Request” also implies that it can fail better than “create” does.
toji
added a commit
that referenced
this pull request
Jul 11, 2017
This brings it inline with all of our other asynchronous calls which use the “request” verbiage. “Request” also implies that it can fail better than “create” does.
toji
added a commit
that referenced
this pull request
Aug 14, 2017
This brings it inline with all of our other asynchronous calls which use the “request” verbiage. “Request” also implies that it can fail better than “create” does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it inline with all of our other asynchronous calls which
use the “request” verbiage. “Request” also implies that it can fail
better than “create” does.
I suspect this is an uncontroversial change, but I'll leave it as a pull request until I can at least bring it up on the call today.