Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added index.html to .gitignore #1185

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

himorin
Copy link
Member

@himorin himorin commented Mar 22, 2021

to prevent events similar to #1184 (review)

(do we need to keep node/npm related lines used(??) for TravisCI?)

@himorin himorin requested a review from Manishearth March 22, 2021 04:08
@Manishearth Manishearth merged commit 4125a66 into immersive-web:main Mar 22, 2021
@toji
Copy link
Member

toji commented Mar 25, 2021

We may need to revert this. The reason why this wasn't part of the ignored files previously is because our hook to publish the rendered spec to the gh_pages branch was failing to commit the index.html if that was there. We should verify whether or not that's still happening, and if so either revert this change or update our Travis scripts to remove it prior to pushing the published changes.

@Manishearth
Copy link
Contributor

ah oops

The publish step should perhaps force add it

@himorin
Copy link
Member Author

himorin commented Mar 26, 2021

We might need smarter one, but current deploy script explicitly excludes gitignore, so I believe we will not have that again.

https://github.com/immersive-web/webxr/blob/main/.github/workflows/deploy.yml#L18

   run: mkdir deploy && rsync -av --exclude=.git --exclude=.gitignore --exclude=deploy . deploy/

@toji
Copy link
Member

toji commented Mar 28, 2021

Ah, good to know! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants