add isPolyfilled properties to be able to interfaces (fixes #41)
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is legit to drop the .js prefix? |
yep, with both ES6 and CommonJS modules |
|
OK, good to know. However, I'd opt for consistency throughout the codebase. Let's stick to .js$ for now. Can change style in one fell swoop later. |
yeah, that's smart. just fixed. |
| @@ -31,6 +31,7 @@ var Eye = { | |||
| * VRDisplay based on mobile device parameters and DeviceMotion APIs. | |||
| */ | |||
| function CardboardVRDisplay() { | |||
| this.isPolyfilled = true; | |||
There was a problem hiding this comment.
I just realised I can remove these since these displays inherit from VRDisplay, which also sets the prop
There was a problem hiding this comment.
Sounds good, you'll update this PR?
|
updated! |
…from native ones (fixes #41)
borismus
added a commit
that referenced
this pull request
Mar 16, 2016
add `isPolyfilled` properties to be able to interfaces (fixes #41)
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.