Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pixel 3 XL #43

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Adding Pixel 3 XL #43

merged 2 commits into from
Dec 10, 2018

Conversation

azmartone
Copy link

Using Display Metrics App

2960x1440 pixels
5.3 x 2.6 inches

xdpi 558.490566
ydpi 553.8461538

@azmartone
Copy link
Author

fixes #42

@azmartone
Copy link
Author

Hey @cvan @thoragio , when you're free, want to review this PR?

@jsantell
Copy link
Contributor

jsantell commented Dec 7, 2018

Looks good to me! Could you rebase, or not include the minified json?

klausw added a commit to klausw/webvr-polyfill-dpdb that referenced this pull request Dec 8, 2018
@azmartone
Copy link
Author

Rebased and omitted dpdb.json

@jsantell
Copy link
Contributor

@azmartone thank you!

@jsantell jsantell merged commit 5e7d1f7 into immersive-web:master Dec 10, 2018
This was referenced Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants