Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take frame time into account in anchor creation, clarify intent #42

Merged
merged 2 commits into from
May 7, 2020

Conversation

bialpio
Copy link
Contributor

@bialpio bialpio commented May 4, 2020

Related: #37.

/cc @thetuvix, @toji.


Preview | Diff

index.bs Outdated Show resolved Hide resolved
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I appreciate the extensive discussion that's gone into making sure this relatively minor change reflects the behavior we want from the platform. Thanks!

Co-authored-by: Alex Turner <[email protected]>
@bialpio
Copy link
Contributor Author

bialpio commented May 7, 2020

Merging now, please open new issues if you think there's anything else that should be addressed here. Thanks for catching this issue with my original approach!

@bialpio bialpio merged commit 745ca53 into master May 7, 2020
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request May 13, 2020
With the latest spec change, WebXR Anchors API should strive to create
anchors such that the anchor location reflects the knowledge of the
world (& the spaces) as of the time of XRFrame used to make the call.
For Chrome's implementation, it means that we should rely of the notion
of stationary & dynamic XRSpaces, and in case the app wants to create
an anchor relative to a space that is considered a dynamic one, we
should use the current knowledge of the world to calculate anchor's pose
w.r.t. a stationary XRSpace that is deemed best - currently, we will
attempt to use local space for anchor creation and fall back to
unbounded reference space.

Spec draft PR with the corresponding change to the spec:
immersive-web/anchors#42

Change-Id: I25398844cd7d92dc8a2af76c8175e6098b099452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194594
Commit-Queue: Piotr Bialecki <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/heads/master@{#768007}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants