Cannot import from immer with webpack 4

[erango]

🐛 Bug Report

When importing immer to React with Webpack 4, I get this exception:
Error was not caught ReferenceError: require is not defined at Module.../node_modules/immer/dist/immer.mjs (immer.mjs:1066)

To Reproduce

Use a react + webpack 4 setup, such as the default create-react-app setup.

Expected behavior

Import should work.

Environment

• Immer version: 2.1.2
• Occurs with setUseProxies(true)
• Occurs with setUseProxies(false) (ES5 only)

[egoist]

Related: #331 (comment)

However I can't reproduce this using CRA and the example code.

[mweststrate]

Fun fact: there is not a single 'require' (or import for that matter) statement in 'immer.mjs'.... Make sure to at least upgrade webpack to the latest version of 4, as there has been some bugs with this in the past, for example: webpack/webpack#8491

…

On Wed, Mar 13, 2019 at 10:55 AM EGOIST ***@***.***> wrote: Related: #331 (comment) <#331 (comment)> However I can't reproduce this using CRA and the example code <https://github.com/mweststrate/immer#example>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#333 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhMUkcIYSiqzW_x1t5Hkvm3ifEhLiks5vWMsugaJpZM4bsyWv> .

[erango]

Thanks for the lightning fast response guys! I'll keep you posted

[mohsinulhaq]

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/webpack.config.js#L507

CRA works because of above config
I tried removing mjs from here
build with 2.1.2 fails, while 2.1.3 works

so, for me, #331 (comment)
it failed because we aren't taking care of mjs files in webpack

[mweststrate]

Since it seems fixed with 2.1.3, I think we can close this issue? Could you confirm @erango?

[erango]

Yes 😄 Thanks everyone!