Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AuthComponentBase. #695

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

bitbound
Copy link
Collaborator

@bitbound bitbound commented Aug 1, 2023

I was trying to take a shortcut with AuthComponentBase by not making User nullable when it should be. It wasn't working out so well.

This PR makes it nullable, adds the EnsureUserSet utility method to guard against null values, and refactored derived components.


Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

cmbankester
cmbankester previously approved these changes Aug 3, 2023
Base automatically changed from tech/fix-migrations-all-providers to master August 3, 2023 17:53
@bitbound bitbound dismissed cmbankester’s stale review August 3, 2023 17:53

The base branch was changed.

@bitbound bitbound merged commit 03879a1 into master Aug 3, 2023
@bitbound bitbound deleted the tech/refactor-authcomponentbase branch August 3, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants