Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Wake On LAN #667

Merged
merged 16 commits into from
Jun 23, 2023
Merged

Feature - Wake On LAN #667

merged 16 commits into from
Jun 23, 2023

Conversation

bitbound
Copy link
Collaborator

This PR adds Wake-on-LAN feature. It can be triggered for an individual device or a device group. The server will look for devices that are eligible to wake the offline device by matching either the device group or the public IP address.

Other Changes:

  • Removed some old code.
  • Renamed AgentHubSessionCache (formerly "Service").
  • Added new overload to ToastService.
  • Reduced the initial load of server logs to 1 day.
  • Changed IMessenger registration from Singleton to Scoped.
    • Scoped is essentially per-connection singleton in Blazor Server.
    • Singleton was causing events to trigger in other tabs.
  • Expanded test data.
  • Changed authorization behavior so devices that aren't in groups are no longer considered "public".
    • This was a workaround for a legacy issue that no longer exists.

Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

@bitbound
Copy link
Collaborator Author

I lost power while fixing the unit tests for this. I'll take care of it tomorrow.

@bitbound bitbound requested a review from dkattan June 23, 2023 21:12
@bitbound bitbound merged commit 097e6a4 into master Jun 23, 2023
@bitbound bitbound deleted the feature/wake-on-lan branch June 23, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants