Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 5. #176

Merged
merged 14 commits into from
Nov 25, 2020
Merged

Update to .NET 5. #176

merged 14 commits into from
Nov 25, 2020

Conversation

bitbound
Copy link
Collaborator

Important: I realize Remotely is currently lacking in unit and integration tests. I was pretty newb when I wrote a lot of the foundational code, and I haven't had time to refactor and restructure.

I'd like to start changing that, though. Enough people are starting to depend on Remotely that I want to make sure it's maintainable and lives on. So I need every PR to include automated tests that prove the new functionality is working.

If you have the time and the desire, it would also be incredibly helpful if you included some new tests against services touched by your changes. I know that this is my mess you're cleaning up, so I thank you wholeheartedly for your help. The people who use Remotely appreciate it too. :)

Delete the above and add your PR comments here and delete the above.


Please read the following. Do not delete below this line.


Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to me (Jared Goodwin) so that I retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that I'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Jared Goodwin, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

@bitbound bitbound merged commit 7857aa7 into master Nov 25, 2020
@bitbound bitbound deleted the net5 branch November 25, 2020 01:54
bitbound added a commit that referenced this pull request Jul 26, 2021
* Retarget .NET 5.

* Delete binaries

* Create ClickOnce publish profile.

* Add IncludeAllContentForSelfExtract

* Retarget .NET 5.

* Delete binaries

* Create ClickOnce publish profile.

* Add IncludeAllContentForSelfExtract

* Remove trim publish option.

* Update Program.cs

* Bump .NET Framework apps up to v4.8.

* Remove use of obsolete DatabaseErrorPageMiddleware.

* Delete ClickOnce-Win10-x64.pubxml
bitbound added a commit that referenced this pull request Jul 29, 2021
* Retarget .NET 5.

* Delete binaries

* Create ClickOnce publish profile.

* Add IncludeAllContentForSelfExtract

* Retarget .NET 5.

* Delete binaries

* Create ClickOnce publish profile.

* Add IncludeAllContentForSelfExtract

* Remove trim publish option.

* Update Program.cs

* Bump .NET Framework apps up to v4.8.

* Remove use of obsolete DatabaseErrorPageMiddleware.

* Delete ClickOnce-Win10-x64.pubxml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant