update to new #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows reporting the state of the message pipe and local queue as the crash condition tripped, rather than the state of the world at the time when the crash report finally captures it. Bug: 1017827 Change-Id: I40cba719cf0541cc10f0da4362a8708f167676ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918496 Commit-Queue: Sigurður Ásgeirsson <[email protected]> Reviewed-by: Ken Rockot <[email protected]> Cr-Commit-Position: refs/heads/master@{#716269}
The only remaining use of this API is for filtering interfaces exposed by the browser to renderers. This replaces the Service Manager implementation and Connector API with a one-off filtering implementation inside content/browser, thus allowing other Service Manager dependencies to be stripped away from Content without compromising the security review process. This filtering will eventually be removed once all renderer-exposed interfaces have been migrated to BrowserInterfaceBroker. Bug: 977637 Change-Id: I0d9636b974c7d51199b16e4586a09022a4ced4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910847 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: John Abd-El-Malek <[email protected]> Commit-Queue: Ken Rockot <[email protected]> Cr-Commit-Position: refs/heads/master@{#716270}
At the moment, MADV_FREE DiscardableMemory does not report discardable memory usage for a background dump. Register MADV_FREE discardable memory allocators as memory dump providers in order to provide a total for background dumps. Bug: 1014513 Change-Id: I8b22ca480ff3d0ef52e5b26358975283612e38f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907266 Commit-Queue: Gordon Guan <[email protected]> Reviewed-by: ssid <[email protected]> Reviewed-by: Michael Thiessen <[email protected]> Cr-Commit-Position: refs/heads/master@{#716271}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30dfc066fa35..9f6ea6efa9de Created with: gclient setdep -r src-internal@9f6ea6efa9de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome [email protected] Bug: chromium:996754 Change-Id: I84f11afdf4701d11dd125dc294fbdab2dfe3d535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922290 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716272}
The logic in SiteInstanceImpl::GetSiteForURLInternal() can generate site URLs that only have a scheme (e.g. "custom-scheme:" ). These URLs are not considered valid and GURL::spec() will return an empty string for them. This change replaces several instances of spec() with possibly_invalid_spec() in code that logs a site or lock URL. This will allow us to actually see these scheme-only cases in the logs instead of an empty URL. This will also avoid DCHECKs in spec() if the scheme-only cases happen to be encountered in debug builds. Change-Id: I45fc99b0d32b0e9887718d5d0c74fd7ddb890200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912991 Auto-Submit: Aaron Colwell <[email protected]> Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Aaron Colwell <[email protected]> Cr-Commit-Position: refs/heads/master@{#716273}
https://chromium.googlesource.com/catapult.git/+log/f886512bde35..991721505aa9 git log f886512bde35..991721505aa9 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 [email protected] [Telemetry] Clean up page_run_end_to_end_unittest.py Created with: gclient setdep -r src/third_party/catapult@991721505aa9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel [email protected] Bug: chromium:1025765 Change-Id: I6ae1e16a57e6c09c6fe297e507c196d01ddd7923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922291 Reviewed-by: chromium-autoroll <[email protected]> Commit-Queue: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#716274}
Rather than checking whether PrefServiceBridge has been constructed, check whether native has initialized, as that's the blocking factor for whether this sync logic can execute. This change is a prerequisite to some further PrefServiceBridge refactoring. Bug: 1016957 Change-Id: I9cf9785efa31983b5f159ae3465b6a5174776a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913075 Commit-Queue: Natalie Chouinard <[email protected]> Reviewed-by: Patrick Noland <[email protected]> Cr-Commit-Position: refs/heads/master@{#716275}
A tex-image-canvas-corruption has begun failing only on Nexus 9. Suppressing the test there while the root cause is found. [email protected] Test= webgl_conformance_tests conformance/textures/misc/tex-image-canvas-corruption.html Bug: 1025790 Change-Id: Icfc6a075e49723f243d22067d50ff8530449a1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920723 Reviewed-by: Jonathan Ross <[email protected]> Commit-Queue: Jonathan Ross <[email protected]> Cr-Commit-Position: refs/heads/master@{#716276}
As part of creating a shared accessibility/ directory, a significant number of presubmit errors/warnings were surfaced. This CL fixes those. Bug: 706981 Change-Id: I196a5730dc74bee3926aa6ece82cac9e6b4e2f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918274 Reviewed-by: Nektarios Paisios <[email protected]> Commit-Queue: Anastasia Helfinstein <[email protected]> Cr-Commit-Position: refs/heads/master@{#716277}
R=kkhorimoto,javierrobles Change-Id: I8f8be78843e6db7820a7390c09cdb30a86ba5c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918900 Auto-Submit: Chris Hall <[email protected]> Reviewed-by: Javier Ernesto Flores Robles <[email protected]> Reviewed-by: Kurt Horimoto <[email protected]> Commit-Queue: Kurt Horimoto <[email protected]> Cr-Commit-Position: refs/heads/master@{#716278}
https://swiftshader.googlesource.com/SwiftShader.git/+log/b87324f822f3..79afb7620a69 git log b87324f822f3..79afb7620a69 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 [email protected] Remove vulkan.hpp Created with: gclient setdep -r src/third_party/swiftshader@79afb7620a69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel [email protected] Bug: chromium:b/144696871 Change-Id: Ifda182e6221b62b6050dab9151be287d88bd3376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922287 Reviewed-by: chromium-autoroll <[email protected]> Commit-Queue: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#716279}
Move methods related to network usage and privacy from PrefServiceBridge to PrivacyPreferencesManager. This is part of a larger change to limit PrefServiceBridge to only feature-agnostic logic related to the native PrefService. Bug: 1016957 Change-Id: I7ca586e348c97a686591856ad0af35b36c9dc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918328 Commit-Queue: Natalie Chouinard <[email protected]> Reviewed-by: Yusuf Ozuysal <[email protected]> Reviewed-by: Brandon Wylie <[email protected]> Cr-Commit-Position: refs/heads/master@{#716280}
These tests are being flagged as "unexpected passes" by wpt runner. They were failing previously because of missing features, primarily around wpt metadata builder support (such as variants, multi-globals, etc). Change-Id: I28b5736cd3a285f42d9e23a5a9e72fbeb8a44652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922335 Commit-Queue: Luke Z <[email protected]> Commit-Queue: Robert Ma <[email protected]> Auto-Submit: Luke Z <[email protected]> Reviewed-by: Robert Ma <[email protected]> Cr-Commit-Position: refs/heads/master@{#716281}
While trying to update Intel drivers a series of tests have begun failing on Windows. Landing suppressions until we can sort out the state of the drivers. [email protected] TEST=webgl2_conformance_gl_passthrough_tests Bug: 1016459 Change-Id: I112041a0d0481118b7a2cb4ec4701a4cb89dd40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922288 Reviewed-by: Jonathan Ross <[email protected]> Commit-Queue: Jonathan Ross <[email protected]> Cr-Commit-Position: refs/heads/master@{#716282}
…r exits early"" This reverts commit 8fd1f75. Reason for revert: This appears to be the culprit for new failures, including: https://ci.chromium.org/p/chromium/builders/ci/win-asan/8519 and https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/42424 Original change's description: > Reland "Kill the software_reporter_tool process if the browser exits early" > > This is a reland of 71d76ec with one change: > fix the unit test on Windows 7. > > Original change's description: > > Kill the software_reporter_tool process if the browser exits early > > > > Assign the software_reporter_tool process to a job object with the > > KILL_ON_JOB_CLOSE flag, so that the process will automatically be killed > > if it's still running when the browser exits. > > > > R=proberge > > > > Bug: 1016939 > > Change-Id: I87dfc907cc853add1721f80c589051896ed4e857 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918106 > > Commit-Queue: Joe Mason <[email protected]> > > Reviewed-by: proberge <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#715997} > > Bug: 1016939 > Change-Id: I03bf2781d3ef38e993310a3ec72fbdefd294fcc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921694 > Reviewed-by: proberge <[email protected]> > Commit-Queue: Joe Mason <[email protected]> > Cr-Commit-Position: refs/heads/master@{#716197} [email protected],[email protected] Change-Id: I550cd7ca853a19b73c57d300250844d13784566a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919755 Reviewed-by: Matthew Wolenetz <[email protected]> Commit-Queue: Matthew Wolenetz <[email protected]> Cr-Commit-Position: refs/heads/master@{#716283}
This provides support for --gzip-output in grit/build.py, which: 1. Compresses individual output files. 2. Appends .gz to the compressed output files (e.g. messages.json -> messages.json.gz). This makes it fairly simple to convert an extension (e.g. chromevox) to use compressed l10n files. Other than setting gzip_output = true in the .gn file, the only other required change is updating any test dependencies. Bug: 1023568 Change-Id: I8318b1d87b828b512f890c6f2cf6d4d22462ed7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913610 Commit-Queue: Steven Bennetts <[email protected]> Reviewed-by: David Tseng <[email protected]> Reviewed-by: Andrew Grieve <[email protected]> Cr-Commit-Position: refs/heads/master@{#716284}
https://skia.googlesource.com/skia.git/+log/9042d46ff46c..a8ea23db0091 git log 9042d46ff46c..a8ea23db0091 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 [email protected] Run nanobench on droids.gif 2019-11-18 [email protected] Metal: Fix buffer alignment issues on Mac 2019-11-18 [email protected] restructure EdgeClipper to accommodate other callers (e.g. half-plane) 2019-11-18 [email protected] [infra] Update docs with respect to Go modules. 2019-11-18 [email protected] Add SampleLocationsTestOp::onPrePrepare Created with: gclient setdep -r src/third_party/skia@a8ea23db0091 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel [email protected] Bug: chromium:1023191 Change-Id: I3a8ceae98c6f7491134791dcf8e0a0a9319a7578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922289 Reviewed-by: chromium-autoroll <[email protected]> Commit-Queue: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#716285}
Bumps expiry and rm's bengr as owner Bug: 1025851 Change-Id: I5b35d57d0c869598bc66c672645e4f2197567195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922247 Reviewed-by: Tarun Bansal <[email protected]> Commit-Queue: Robert Ogden <[email protected]> Cr-Commit-Position: refs/heads/master@{#716286}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eafa050d..839a6520 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel [email protected],[email protected] Change-Id: Ie480b08d3584640774473b1475b43d8e5afd2dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921542 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716287}
Make the WebAuthn UI "back" button invoke the request restart logic on every dialog that it is shown by changing the default implementation in AuthenticatorRequestSheetModel::OnBack(). Previously, the default implementation was to return to the transport selection UI *without* restarting the request, which is not a particularly useful implementation and was rarely used. This also fixes a bug that was caused by the account selection back button using said default implementation. Fixed: 1020757 Change-Id: Id3af91ad2eab756f3dae7cf55410f1b46b18810b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902646 Commit-Queue: Martin Kreichgauer <[email protected]> Reviewed-by: Nina Satragno <[email protected]> Cr-Commit-Position: refs/heads/master@{#716288}
…on_chorded_mouse_button_when_locked.html flaky on linux Bug: 1025944 Tbr: [email protected] Change-Id: Ieed5f7bccecffd6b55a5bceec2037f2f416e1086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921543 Commit-Queue: Tina Wang <[email protected]> Reviewed-by: Tina Wang <[email protected]> Cr-Commit-Position: refs/heads/master@{#716289}
This CL fixes a regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/1874569 BUG=1025574 Change-Id: I102bcad76d853045beb17c2920fae8e27b5c9964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920328 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Peter Conn <[email protected]> Cr-Commit-Position: refs/heads/master@{#716290}
In line with the previous generalization of HttpNegotiateAuthSystem to being HttpAuthMechanismFactory. Bug: 991265 Change-Id: Ifb96bf70345fcb3a1108f22bd5c5013ad038f52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918956 Reviewed-by: Matt Menke <[email protected]> Commit-Queue: Asanka Herath <[email protected]> Cr-Commit-Position: refs/heads/master@{#716291}
Right now, like most Blink mojoms, DOM Storage mojoms are part of the monolithic public platform mojom target. This target builds as part of the private platform implementation for the Blink variant, and as part of the Blink public library for the non-Blink variant. This means that non-Blink dependents must pull in a dependency on the entire public platform library rather than only a few interesting mojom definitions. This change gives DOM Storage mojoms their own mojom target. The tricky bit here is that we don't want both Blink and non-Blink variants to use source_set: the Blink variant should be a source_set linked into the platform impl, but the non-Blink variant should be its own component target. This is because other component targets (like content/browser) may link against it, and we don't want to end up with the same weird export macro overriding situation that we have with Blink variants. So the real meat of this change is to allow mojom_component() GN targets to override export macros (and implicitly, generated target type) for specific variants, so that DOM Storage can define a mojom_component() target for non-Blink consumers to use, while Blink continues to link the Blink variant into its private impl as a source_set. Bug: 1000959 Change-Id: Ief689b87d4c6e38ee997063f85dcedfcf186b8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920008 Reviewed-by: Dave Tapuska <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Commit-Queue: Ken Rockot <[email protected]> Cr-Commit-Position: refs/heads/master@{#716292}
It would be good to know how often shared addresses return only an address string without any derived fields. Change-Id: Ibbe4273bdd42bb95bdefc7ebafc04a701ddab3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919346 Commit-Queue: Rayan Kanso <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Mark Pearson <[email protected]> Cr-Commit-Position: refs/heads/master@{#716293}
Bug: b:144701221 Test: android-sh -c getprop | grep ro.boot.arc_print_spooler Change-Id: I7336cce9687369dc7e62558694c8378b46aab0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921338 Reviewed-by: Yusuke Sato <[email protected]> Commit-Queue: Jesse Schettler <[email protected]> Cr-Commit-Position: refs/heads/master@{#716294}
By virtue of being FYI builders, these builders were specifying 4 cores, which doesn't work so well for macs which always have 8. This CL brings them into line with the other non-FYI mac builders, which don't specify a core count at all. Bug: 1018846, o/35112879 No-Try: True Change-Id: Ic4bbebe62651824b548e2195a5042d64d90e1aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918394 Auto-Submit: Aaron Gable <[email protected]> Reviewed-by: John Budorick <[email protected]> Commit-Queue: John Budorick <[email protected]> Cr-Commit-Position: refs/heads/master@{#716295}
PDF accessibility code would like to get all the links and images on a particular page. With links for example, there are two methods: - uint32_t GetLinkCount(); - bool GetLinkInfo(uint32_t;link_index); The accessibility code has to call GetLinkCount() and then call GetLinkInfo() multiple times. Instead of doing this, just have a unified std::vector<AccessibilityLinkInfo> GetLinkInfo() method to get all the link info at once. Do the same simplification for image info. Bug: 981448 Change-Id: I8ccb9b70d69998f4a6c3a8bf365781d91456a254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917954 Reviewed-by: Kevin Babbitt <[email protected]> Commit-Queue: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/master@{#716296}
Because the origin trial system cannot (yet) support file:// URLS for re-enabling deprecated features, we will temporarily re-enable WCv0 for all file:// URLs. Additionally, this CL renames the function RequiresHtmlImports() to RequiresWebComponentsV0(), as that is more descriptive of how it is used. Bug: 1021137, 1025782, 937746 Change-Id: I54a4794334edeaa25b3e4c2102be60f118f2372b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920482 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Avi Drissman <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Cr-Commit-Position: refs/heads/master@{#716297}
…huts down CastMediaNotificationProvider depends on MediaRouter, which is a keyed service. So the instance held by MediaNotificationService needs to be destroyed in Shutdown(). Change-Id: Idf522c88838f2acc4116005865379b76428bbada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919754 Reviewed-by: Tommy Steimel <[email protected]> Commit-Queue: Takumi Fujimoto <[email protected]> Cr-Commit-Position: refs/heads/master@{#716298}
This is a follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1922288 Where I'm moving the newer Intel failures next to existing ones. And updating them to include the driver version: 26.20.100.7323 [email protected] TEST=webgl2_conformance_gl_passthrough_tests Bug: 1016459 Change-Id: Ie5fde0a06dacdcd07d322e940366c8bf812a7c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923251 Reviewed-by: Jonathan Ross <[email protected]> Reviewed-by: Yuly Novikov <[email protected]> Commit-Queue: Jonathan Ross <[email protected]> Cr-Commit-Position: refs/heads/master@{#716490}
Fix a bug in the test packet maker where the retry token fields were carried over from one packet to another. Change-Id: I1677f15eec976ecc0ba8afbd524a57916d0c3aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922550 Commit-Queue: Zhongyi Shi <[email protected]> Reviewed-by: Zhongyi Shi <[email protected]> Cr-Commit-Position: refs/heads/master@{#716491}
…kerTiming This patch is a part of FetchEvent WorkerTiming patchs. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using blink::PerformanceResourceTiming. This patch extends blink::PerformanceResourceTiming to receive PerformanceMark or PerformanceMeasure from FetchEvent#addPerformanceEntry via Mojo connection, but this feature won't work after this patch is merged because a pair of Mojo endpoints for FetchEvent WorkerTiming aren't connected yet. This will be connected in the other patch. There's a possibility that FetchEvent#addPerformanceEntry is called after PerformanceResourceTiming is constructed. The problem is incomplete PerformanceResourceTiming#workerTiming will be exposed when we access this API before all PerformanceMark/Measure are sent to this workerTiming. This may cause different results from this API when we access it at the different time. We will delay exposing the whole PerformanceResourceTiming object on its workerTiming attribute being complete. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: I6c0cab77321e7eb35b3f33319d8d418b7fbe4a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905288 Commit-Queue: Yuta Kasai <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Cr-Commit-Position: refs/heads/master@{#716492}
# This is an automated release commit. # Do not revert without consulting [email protected]. NOAUTOREVERT=true [email protected] Change-Id: I78d09ea56ce862c799454265bc930efe608afce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922955 Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716493}
We actually don't need this in order to allow for palm rejection on a touchscreen. Update unit test to reflect change. Bug: 1009290 Change-Id: I045ce054158a49366349ed252ee0c57598bfbfa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905037 Reviewed-by: Michael Spang <[email protected]> Commit-Queue: Rob Schonberger <[email protected]> Cr-Commit-Position: refs/heads/master@{#716494}
Bug: 1024825 Change-Id: I8710aeb9cf81657796e9df717d08cd6226f13921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923610 Commit-Queue: Dan Beam <[email protected]> Auto-Submit: Dan Beam <[email protected]> Reviewed-by: Demetrios Papadopoulos <[email protected]> Cr-Commit-Position: refs/heads/master@{#716495}
Using wpt-import in Chromium c2ab7f2. With Chromium commits locally applied on WPT: e83dd93 "Limit backtracking on regexp called from blink." c8b6e1c "Chromedriver] Fix PerformAction to support multi touch points cases" 500a74f "Add a runtime flag to enforce strict MIME type checks for workers." eb07c68 "[scroll-snap] Add keyboard test to WPT" 8360e2e "Add a wpt test for issue 916631." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I473a3c27e6100041d54d5ca6ffc9fca256e7a59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923507 Reviewed-by: WPT Autoroller <[email protected]> Commit-Queue: WPT Autoroller <[email protected]> Cr-Commit-Position: refs/heads/master@{#716496}
- Disabling WebAPK install is still possible via the WebAPK server - WebAPKs launched in 2017. We have not needed to disable the feature since launch BUG=1022975 Change-Id: I19079192683d72df46159254aa263d267f40720a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907200 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Yaron Friedman <[email protected]> Reviewed-by: Glenn Hartmann <[email protected]> Cr-Commit-Position: refs/heads/master@{#716497}
This reverts commit 12e7fee. Reason for revert: crbug/1025982 Original change's description: > Reland "Support grdp files in translation screenshot presubmit" > > This is a reland of 2308d07 > > Original change's description: > > Support grdp files in translation screenshot presubmit > > > > Translation screenshots project requires Chrome devs to upload UI > > screenshots along with string changes in .grd and .grdp files. These > > are XML files containing all user visible strings in Chrome. > > > > Translation screenshots has a presubmit checks that extracts the > > list of modified strings, looks for image files associated with these > > strings and warns the developer to add them if they are missing. > > > > This presubmit parses .grds to extract the list of modified strings but > > it skips <part> tags which are used to reference .grdp files. As a > > result, the presubmit currently ignores string changes in .grdp files. > > .grdp files contain the majority of UI strings in Chrome, so the lack of > > presubmit checks for them results in low translation screenshot coverage. > > > > This CL changes how .grdp files are loaded in the presubmit: Previously, > > they were written in a temporary directory alongside a fake .grd file > > that referenced the loaded .grdp file. The code loaded the fake .grd file > > which resulted in loading the strings in the actual .grdp file. However, > > test mocks override all os.path methods which in turn breaks temporary > > directory creation. As a result, it was not possible to properly test > > the .grdp loading code, so we skipped <part> tags as a workaround. > > > > The new loading code writes a temporary copy of the .grdp file and wraps > > its contents with proper tags so that it can be loaded as a .grd file > > instead. This avoids the need to create a temporary directory and is > > fully testable. > > > > The end result is that Translation Screenshots presubmit will now ask > > Chrome devs to upload screenshots for changes in .grdp files. This should > > significantly increase the coverage of strings with translation screenshots, > > leading to better quality in string localizations. > > > > Bug: 924652 > > Change-Id: Iae7933e8147cefdabc15ef21d2b6daa43d5002bc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875554 > > Reviewed-by: anthonyvd <[email protected]> > > Reviewed-by: Jochen Eisinger <[email protected]> > > Commit-Queue: Mustafa Emre Acer <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#714550} > > Bug: 924652 > Change-Id: Iaf0f68f8abdccd3bca66b4b611bf53d8337d347b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912835 > Reviewed-by: anthonyvd <[email protected]> > Reviewed-by: Jochen Eisinger <[email protected]> > Commit-Queue: Mustafa Emre Acer <[email protected]> > Cr-Commit-Position: refs/heads/master@{#716224} [email protected],[email protected],[email protected] Change-Id: Id5265d9bffe86e3179784325eff357f9ac758967 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923155 Reviewed-by: Mustafa Emre Acer <[email protected]> Commit-Queue: Mustafa Emre Acer <[email protected]> Cr-Commit-Position: refs/heads/master@{#716498}
This is for QuicTransport. Discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-api-owners-discuss/uoQG64TjVcU Due to https://crbug.com/734880, it's necessary to explicitly register standard schemes (schemes that use authorities and paths) to have them parsed correctly. Bug: 1011392, 734880 Change-Id: I883c68da8230bc74fc48a1969da759f15cd9882d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905289 Commit-Queue: Yutaka Hirano <[email protected]> Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Ryan Sleevi <[email protected]> Cr-Commit-Position: refs/heads/master@{#716499}
It's a regression issue caused by https://chromium-review.googlesource.com/c/chromium/src/+/1882205. This CL used the original source window's CreateParams for the newly created browser window for the dragged tab, so if the source window's initial show state is MAXIMIZED, the newly created browser window will also have MAXIMIZED show state. On Chrome OS, a MAXIMIZED window can't be moved or resized, thus there is no WindowResizer created to change the window bounds. Thus the tab can't be dragged out. This CL reverts the initial show state of the new browwser window to DEFAULT show state. Bug: 1023871 Change-Id: I988d85cd03909b84cb06f5f0badef7b8de6fda47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922330 Reviewed-by: Scott Violet <[email protected]> Commit-Queue: Xiaoqian Dai <[email protected]> Cr-Commit-Position: refs/heads/master@{#716500}
The Back and Reload buttons no longer receive the default insets of GetLayoutInsets(TOOLBAR_BUTTON), i.e 6 or 12 pixels depending on touch ui, when they are used in the web app frame toolbar. Instead, they receive the same insets as the web app menu button, i.e. 0 or 2 pixels depending on focus mode. This allows the buttons to move closer together, and avoids the minimal-ui controls increasing the web app frame toolbar height on Windows 10. Bug: 1025093 Change-Id: If518e57912442b44f34de1f8c6d1927809f58b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915642 Reviewed-by: Trent Apted <[email protected]> Commit-Queue: Eric Willigers <[email protected]> Cr-Commit-Position: refs/heads/master@{#716501}
This CL adds the implementation to find the best matching filter for an intent, so we can use it to set the preferred app. BUG=853604 Change-Id: Id22922aab1a6fa783e3484eb93d2004f58521c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921026 Commit-Queue: Maggie Cai <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Reviewed-by: Nancy Wang <[email protected]> Cr-Commit-Position: refs/heads/master@{#716502}
Removes public Tab API requestFocus, and lets the callers use Tab.getView() directly. Bug: 995903 Change-Id: I3836575ce064640a6344f4cc3bc9bc6cbbee9d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910820 Reviewed-by: David Trainor <[email protected]> Commit-Queue: Jinsuk Kim <[email protected]> Cr-Commit-Position: refs/heads/master@{#716503}
[email protected] Bug: 780914 Change-Id: I1336e2a66d9276f2bc813623a84fa9c9d522b85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913287 Commit-Queue: Andrew Bennetts <[email protected]> Reviewed-by: Caleb Rouleau <[email protected]> Cr-Commit-Position: refs/heads/master@{#716504}
During helping https://crrev.com/c/1870161, I find that there's another new target mojom_modules and it seems to be a better place to put mojom files for service workers. This CL is to make it easier to understand which Mojo types can be used in service worker mojom files since it'll match with the layers in blink/renderer. Bug: n/a Change-Id: I3838a1c730ab3d120857b24c4b2c527dde7ebde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900790 Reviewed-by: Kinuko Yasuda <[email protected]> Commit-Queue: Makoto Shimazu <[email protected]> Cr-Commit-Position: refs/heads/master@{#716505}
…vels" This reverts commit fe4a28d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 716491 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZlNGEyOGRmOTE1NzQ4NzZjNDAxMTAxZDI3YTVhNmY0ZDllMjRlYmMM Sample Failed Build: https://ci.chromium.org/b/8896391819190311952 Sample Failed Step: net_unittests Original change's description: > Flip FLAGS_quic_reloadable_flag_quic_close_all_encryptions_levels > > Fix a bug in the test packet maker where the retry token fields > were carried over from one packet to another. > > Change-Id: I1677f15eec976ecc0ba8afbd524a57916d0c3aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922550 > Commit-Queue: Zhongyi Shi <[email protected]> > Reviewed-by: Zhongyi Shi <[email protected]> > Cr-Commit-Position: refs/heads/master@{#716491} Change-Id: Ie149714725e8f8fb410a2adae01729d453e746b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922736 Cr-Commit-Position: refs/heads/master@{#716506}
This is the first general framework for AppServiceAppWindowLauncherController. There will be some separate CLs to handle the special cases for different app types and some other related app handling. For example: 1. Arc apps task id related handling 2. Crostini's termal apps. 3. Opened with browser tab apps instance. 4. ActiveUserChanged 5. MultiProfileAppWindowLauncherController 6. Update browser tests. 7. Consider if no windows is active. Design doc: go/app-service-instance-registry-design-doc go/appservice-for-per-app-time-limit-design-doc BUG=1011235 Change-Id: I0e6049375c96ad011897d9a62e82c2bda7d19fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906848 Commit-Queue: Nancy Wang <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Cr-Commit-Position: refs/heads/master@{#716507}
This change partially addresses the code duplication problem where workers would need methods to validate their RenderProcessHost pointer before calling a binder method on it. Binders taking a pending receiver and an origin go through the generic binder helper now. Also cleans up redundant comments in render_process_host.h Bug: 936482 Change-Id: I676098a5763be9d818b624a63a8e001feba4f7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889010 Commit-Queue: Oksana Zhuravlova <[email protected]> Reviewed-by: Matt Falkenhagen <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Ken Rockot <[email protected]> Cr-Commit-Position: refs/heads/master@{#716508}
If I understand correctly, as the data is provided as an array of the correct type, the individual calls to Set should not make any difference. [email protected] Bug: chromium:1008840 Change-Id: I40e43364cebd4fa239d6eec8305f7fb85478293b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921982 Reviewed-by: Kentaro Hara <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Cr-Commit-Position: refs/heads/master@{#716509}
This CL removes the CreateUninitializedOrNull function from Float32Array and adds it to DOMFloat32Array. This allows us to remove one external use of Float32Array. [email protected] Bug: chromium:1008840 Change-Id: I29b57410d1b5d543ff076ffc91fbced09028ddd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921970 Reviewed-by: Kentaro Hara <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Cr-Commit-Position: refs/heads/master@{#716510}
It's flaky on Win7 Tests bots. [email protected] Bug: 1026121 Change-Id: I7823806a90863dde8a13cef8cdf6bb60be9ce2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923769 Reviewed-by: Alexey Baskakov <[email protected]> Commit-Queue: Alexey Baskakov <[email protected]> Cr-Commit-Position: refs/heads/master@{#716511}
This CL converts ProcessInternalsHandler mojom interface client in content to use BrowserInterfaceBroker. ProcessInternalsUI gotten from WebUI of WebContents is used to register its binder. Bug: 1006361, 1002647 Change-Id: I77217607682325390d3739824fde5c68b4e411c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905299 Commit-Queue: Miyoung Shin <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Oksana Zhuravlova <[email protected]> Cr-Commit-Position: refs/heads/master@{#716512}
Bug: 1007776 Change-Id: I278ff4ededb59352a2394f9d30c6920d7270bd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923226 Reviewed-by: Makoto Shimazu <[email protected]> Commit-Queue: Matt Falkenhagen <[email protected]> Cr-Commit-Position: refs/heads/master@{#716513}
base::Hash() is deprecated and is being replaced by base::FastHash(). The output of base::FastHash() is only fixed within the lifetime of a single process, so if the code depends on the mapping of inputs to hash outputs not changing over time, base::PersistentHash() must be used instead. Bug: 1025358 Change-Id: I59ba6e4329505d9e66983669a8bb2b5bbb6fd406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918355 Commit-Queue: Daniel Cheng <[email protected]> Auto-Submit: Daniel Cheng <[email protected]> Reviewed-by: Peter Kotwicz <[email protected]> Cr-Commit-Position: refs/heads/master@{#716514}
… non-boxes An inline element can have will-change:transform to force compositing. Previously we didn't store the reason in the transform node. Change-Id: I78ef647b842a330e8e118dc31967872872be250a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922548 Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/master@{#716515}
This is similar to crrev.com/c/1861294 but for update(). Script fetches for update check happen on the browser and are managed by ServiceWorkerUpdateChecker so pass some information to ServiceWorkerUpdateChecker too. This CL has a behavioral change. The 'Referer' header of the request triggered by update() in a document/service worker will be changed. Before this CL it was the url of the top-level script but after this CL it is document/service worker's url. This behavior is consistent with the spec. Bug: 937177 Change-Id: I57e9ce7c91a748ad549a49e4e46c7890dcca2903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905028 Commit-Queue: Kenichi Ishibashi <[email protected]> Reviewed-by: Hiroki Nakagawa <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Cr-Commit-Position: refs/heads/master@{#716516}
…h a native app." This reverts commit c54a52f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 716480 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M1NGE1MmZhYjAyOGNjMzUyN2NiNTU1M2MyYzM0NzVhZmRiMzQ3ZjUM Sample Failed Build: https://ci.chromium.org/b/8896391912034348560 Sample Failed Step: browser_tests Original change's description: > Allow background mode while an extension is communicating with a native app. > > Add support for enabling background mode while an extension capable of > accepting inbound native messaging launch requests is active. Allow > cooperating native apps to launch Chrome without a browser window when > initiating communications with a cooperating extension. > > Bug: 967262 > Change-Id: I61353c0becb341ad3e08a5a8635e171f9f9bd59b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898894 > Reviewed-by: Sergey Ulanov <[email protected]> > Reviewed-by: Drew Wilson <[email protected]> > Reviewed-by: Tommy Martino <[email protected]> > Reviewed-by: Sergei Datsenko <[email protected]> > Commit-Queue: Sam McNally <[email protected]> > Cr-Commit-Position: refs/heads/master@{#716480} Change-Id: I5a0c8cf9b53b96dab35dc5a8535271816322df13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923335 Cr-Commit-Position: refs/heads/master@{#716517}
This reverts commit bf41b33. Reason for revert: This is a culprit CL which breaks compilation on linux-archive-dbg builder. Some gn deps missing? https://ci.chromium.org/p/chromium/builders/ci/linux-archive-dbg/6100 Original change's description: > Move mojom files for service workers in blink to mojom_modules > > During helping https://crrev.com/c/1870161, I find that there's another new > target mojom_modules and it seems to be a better place to put mojom files for > service workers. This CL is to make it easier to understand which Mojo types > can be used in service worker mojom files since it'll match with the layers > in blink/renderer. > > Bug: n/a > Change-Id: I3838a1c730ab3d120857b24c4b2c527dde7ebde6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900790 > Reviewed-by: Kinuko Yasuda <[email protected]> > Commit-Queue: Makoto Shimazu <[email protected]> > Cr-Commit-Position: refs/heads/master@{#716505} [email protected],[email protected] Change-Id: Iab939da67e0bfc763cccb6e4ec0560adc11bac38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923785 Reviewed-by: Alexey Baskakov <[email protected]> Commit-Queue: Alexey Baskakov <[email protected]> Cr-Commit-Position: refs/heads/master@{#716518}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to new @20191119