Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SingleDimensionPermutationTransform assertion #375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: SingleDimensionPermutationTransform assertion #375

wants to merge 2 commits into from

Conversation

bogovicj
Copy link
Contributor

@bogovicj bogovicj commented Feb 12, 2025 •
edited
Loading

  • fixes incorrect assertion

@bogovicj
fix: SingleDimensionPermutationTransformAssertion
b0570ae 
* fixes check that prevents permutation of first dimension
@bogovicj
Copy link
Contributor Author

bogovicj commented Feb 12, 2025 •
edited
Loading

An assertion in SingleDimensionPermutationTransform is incorrect - it will wrongly raise an error for d==0 (permuting the first dimension)

This PR fixes it.

Edit: Adds a test that fails using the current code, and passes after this small fix

@bogovicj bogovicj changed the title fix: SingleDimensionPermutationTransformAssertion fix: SingleDimensionPermutationTransform assertion Feb 12, 2025
@bogovicj bogovicj added bug and removed bug labels Feb 12, 2025
@bogovicj
test: more thorough SingleDimensionPermutationTransform
8bc8196 
* test Views.permuteCoordinatesInverse for all dimensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bogovicj