fix(buildURL): ensure operation is idempotent #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to ensure the
buildSrcSet
operation isidempotent. Prior to this PR, code modified the input-parameters,
params
, causing identical calls tobuildSrcSet
to produce differentresults.
Now, the input
params
are copied into a newqueryParams
object andthis object is passed to callers requiring
params
. A test has beenwritten to show that the behavior has changed from the behavior detailed
in issue #158––the input
params
object remains unchanged after callingbuildSrcSet
and that callingbuildSrcSet
multiple times producesthe same result (given the same inputs).
I also ripgrep'd through the repo with
rg 'params.[:alpha:]'
and withrg 'params\['
to ensureparams
is never mutated (i.e. it neverappears on the left hand side of any expression).
Tests have been added to ensure that
_buildParams
:Tests have been added to ensure that calling
buildURL
:Tests have been added to ensure that
buildSrcSet
:Closes #158