Make sure imgs with src='' don't misreport their hiddenness

imgix · May 19, 2015 · 1802cea · 1802cea
1 parent 90cbac8
commit 1802cea
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/core.js b/src/core.js
@@ -2036,8 +2036,14 @@ imgix.FluidSet = function (options) {
 };
 
 imgix.FluidSet.prototype.updateSrc = function (elem, pinchScale) {
+  // An empty src attribute throws off the 'hidden' check below,
+  // so we need to give it something to actually fill it up
+  if (elem.hasAttribute('src') && elem.getAttribute('src') === '') {
+    elem.setAttribute('src', imgix.getEmptyImage());
+  }
+
   // Short-circuit if the image is hidden
-  if (!elem.getClientRects().length) {
+  if (!elem.offsetWidth && !elem.offsetHeight && !elem.getClientRects().length) {
     return;
   }
 
@@ -2096,6 +2102,7 @@ imgix.FluidSet.prototype.updateSrc = function (elem, pinchScale) {
     return;
   }
 
+
   if (!elem.fluidUpdateCount) {
     elem.fluidUpdateCount = 0;
   }