Skip tasks v0.4.0 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdrasil
reviewed
Oct 8, 2020
| @@ -63,6 +63,12 @@ To see a list of all available tasks with their descriptions: | |||
| $ crystal sam.cr help | |||
| ``` | |||
|
|
|||
| To skip a task or prerequisite task: | |||
There was a problem hiding this comment.
Let's maybe make it a bit more clear:
To skip a task or prerequisite task specify it's path with "~" prefix
| @@ -52,6 +52,12 @@ describe Sam do | |||
| Container.tasks.should eq(["db:schema", "db:with_argument"]) | |||
| end | |||
| end | |||
| context "with arguments" do | |||
There was a problem hiding this comment.
please add an empty line between blocks
| @@ -35,6 +35,7 @@ module Sam | |||
|
|
|||
| # Launch current task. Prerequisites are invoked first. | |||
| def call(args : Args) | |||
| return if args.raw.find {|x| "~#{path}" == x } | |||
There was a problem hiding this comment.
Let's grep all tasks that need to be skipped in Args class constructor into @ignore_tasks variable (and remove ~ from the beginning). This way #raw doesn't include any Sam arguments and here we can do args.ignore_tasks.include?(path)
P.S. Also add an empty line after guard clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15