-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only partial re-export of cookie
types?
#23
Comments
Thanks, that makes sense, would you provide a PR? |
I'll see what I can do. 😄👍 |
Er, which option do you prefer? Exporting "everything" or nothing? |
Maybe we leave current reexports as they are to avoid api breaking and just add |
That seems decent enough, yeah. 👍 |
It's published, thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So I noticed that there are some
pub use cookie::<Whatever>
s in tower-cookies, but it only covers some of the types. Like if you try to doyou are told
and there's no
SameSite
to import fromtower_cookies
. Obviously I could just add a dependency oncookie
and import it from there, but I feel like this library would be less confusing if it either exported all ofcookie
(or at least the parts that are part of the cookie creation API) or none ofcookie
; exporting only parts makes the API surface only partially accessible "by default."The text was updated successfully, but these errors were encountered: