Update docker-compose files to include extra_hosts #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set host.docker.internal to host-gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes xdebug when using Docker for Linux, by manually adding the 'host.docker.internal' DNS name.
Ops' xdebug config refers to the debugging client's host using the name 'host.docker.internal', which only exists by default on Docker Desktop; so xdebug can't connect to the host machine on Docker for Linux. This PR updates the docker-compose files for the apache backends to manually add that 'host.docker.internal' to the hosts file using Docker's magic
host-gatewayreference. This is the official approach and shouldn't affect Docker Desktop - see this issue.I've tested and this correctly updates the containers' hosts file, and xdebug is working now.