update compileTableExists definition

[eithed]

Within laravel/framework#53006 definition of compileTableExists method has changed - this PR aligns the definition to the change.

This also means that 5.*|6.*|7.*|8.*|9.*|10.* require for illuminate/database will no longer apply though.

Think you could do __call like this for this (and other methods like compileColumnListing, compileGetAllTables etc)

public function __call(string $name, array $arguments):mixed {
   if (method_exists(get_parent_class($this), $name))
   return $this->stringy([
      'type' => $name,
      'args' => $arguments,
      'sql' => parent::$name($arguments)
  ]);

  throw RuntimeException(sprintf("Method %s does not exist on parent", $name));
}

so that support for different versions still remains

Summary by CodeRabbit

• Bug Fixes
  • Improved table existence checking mechanism by adding database and table parameters to the schema grammar method.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request modifies the compileTableExists method in the FakeSchemaGrammar class. The method's signature is updated to accept two new parameters: $database and $table. This change allows the method to pass these parameters to the parent class's compileTableExists method, ensuring that the SQL query generation utilizes these values for more accurate table existence checks.

Changes

File	Change Summary
src/FakeSchemaGrammar.php	Updated compileTableExists method signature to include $database and $table parameters. Internal logic adjusted to utilize these parameters in SQL generation.

Poem

🐰 A rabbit's tale of schema delight,
Parameters dancing, queries taking flight,
Database and table, now hand in hand,
Compiling existence with a magical command!
Code evolves, precision takes the stage 🔍

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/FakeSchemaGrammar.php (1)

152-157: Consider adding argument logging for consistency.

For consistency with other methods like compileColumns, consider including the arguments in the metadata:

     public function compileTableExists($database, $table)
     {
         return $this->stringy([
             'type' => 'tableExists',
+            'args' => ['database' => $database, 'table' => $table],
             'sql' => parent::compileTableExists($database, $table),
         ]);
     }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6255bed and d0b0c8e.

📒 Files selected for processing (1)

• src/FakeSchemaGrammar.php (1 hunks)

🔇 Additional comments (1)

src/FakeSchemaGrammar.php (1)

152-157: LGTM! Implementation correctly aligns with Laravel's changes.

The updated method signature and implementation properly match the parent class while maintaining the class's pattern of wrapping SQL queries with metadata.

Let's verify this matches Laravel's implementation:

[joelbutcher]

@imanghafoori1 Please can you take some time to review this PR? I also need this change adding to fix a broken CI pipeline with upgrading the Laravel version in a repo at work.

[imanghafoori1]

I think you have restrict the compatible version of Laravel to v11 in the composer.json file as well and merge into the v11 branch.

[eithed]

Going to close it then given that v11 already solves this problem

[imanghafoori1]

You can amend or do a git reset and git push --force on this branch to update your PR

[eithed]

Ah, sorry, v11 indeed is still affected. Updated composer.json

[imanghafoori1]

You may also update the GitHub actions .yml file to run the tests only with laravel v11 in this PR.

[imanghafoori1]

I merged the PR for now, you can install v11 onto your project before the new version is released.
If you see any test missing related to this method feel free to open a PR for it.
Thanks