Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to initialization signature #149

Closed
imakewebthings opened this issue Nov 21, 2013 · 2 comments
Closed

Change to initialization signature #149

imakewebthings opened this issue Nov 21, 2013 · 2 comments
Labels
done-needs-doc-update
Milestone
1.1

Comments

@imakewebthings
Copy link
Owner

Add an option, slideSelector, that does the same job as the first parameter to $.deck(). Make this option required, and allow only the options object to be passed to init. Make the current signature act as an alias for the new one.
@imakewebthings imakewebthings mentioned this issue Nov 21, 2013
Closed
imakewebthings added a commit that referenced this issue Dec 1, 2013
@imakewebthings
#149, move slide selector to an option, alias old init signature
6e0b82b
@imakewebthings
Copy link
Owner Author

Done, but following the 1.0 convention for options this is options.selectors.slides. Doc update to come, but the change is in master.

@imakewebthings
Copy link
Owner Author

This is included in the 1.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done-needs-doc-update
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@imakewebthings