Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interlaced option #23

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Add interlaced option #23

merged 4 commits into from
Oct 4, 2019

Conversation

luckyraul
Copy link
Contributor

@luckyraul luckyraul commented Jul 17, 2019

@sindresorhus create new PR

@sindresorhus
Copy link
Contributor

This needs to be documented. [,,] - #16 (comment)

@sindresorhus
Copy link
Contributor

I think you need to work more on the docs. Interlaced and progressive are not the same thing.

@luckyraul
Copy link
Contributor Author

@sindresorhus
Copy link
Contributor

@luckyraul That doesn't matter. We have high standards for the docs.

@kevva
Copy link
Contributor

kevva commented Oct 2, 2019

@sindresorhus, I believe interlaced is just a flag for generating progressive images. I just think "progressive" is the general description of it.

@sindresorhus
Copy link
Contributor

Interlaced is the opposite of progressive.

@kevva
Copy link
Contributor

kevva commented Oct 2, 2019

Every article and documentation I read is referring to progressive rendering when mentioning interlacing. I don't know for sure though. You can read about it on OptiPNG own documentation as well http://optipng.sourceforge.net/pngtech/optipng.html.

@luckyraul
Copy link
Contributor Author

Interlacing, useful for a faster, progressive rendering, is another component of the PNG image type that affects compression.
http://optipng.sourceforge.net/pngtech/optipng.html

@kevva
Copy link
Contributor

kevva commented Oct 3, 2019

From http://optipng.sourceforge.net/optipng-0.7.7.man.pdf:

If the interlace type 0 is selected, the output image shall be non-interlaced (i.e. progressive-scanned). If the interlace type 1 is selected, the output image shall be interlaced using the Adam7
method. By default, the output shall have the same interlace type as the input.

To me that sounds like "progressive rendering" and "progressive scanned" are two different things.

@kevva
Copy link
Contributor

kevva commented Oct 3, 2019

@luckyraul, can you fix the merge conflicts?

@kevva
Copy link
Contributor

kevva commented Oct 3, 2019

Thanks, I will merge this tomorrow.

@kevva kevva changed the title interlace option Add interlaced option Oct 4, 2019
@kevva kevva merged commit ef42c2d into imagemin:master Oct 4, 2019
@luckyraul luckyraul deleted the interlace branch October 4, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants