Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy::into_iter_on_array error in decoder #116

Merged
merged 2 commits into from
Nov 23, 2019

Conversation

scottmcm
Copy link
Contributor

Rust is trying to add IntoIterator for arrays, which would break this. So might as well do it the way that's forward-compatible and also shorter.

@scottmcm
Copy link
Contributor Author

scottmcm commented Oct 30, 2019

CI failure doesn't look like the fault of this change:

failed to parse manifest at /home/travis/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/cfg-if-0.1.10/Cargo.toml
(All the other builds are fine)

@CryZe
Copy link
Contributor

CryZe commented Oct 30, 2019

Looks like rayon isn't actually compatible with 1.28 anymore (due to some indirect dependency on the latest cfg-if).

@lovasoa
Copy link
Contributor

lovasoa commented Oct 30, 2019

Maybe Cargo.lock should be committed...

@CryZe
Copy link
Contributor

CryZe commented Oct 30, 2019

Nah, you don't commit Cargo.lock for libraries. Then CI would pass but it would still fail to build on 1.28 for everyone depending on this crate. One solution is to depend on cfg-if =0.1.9, but that's probably just causing even more problems, so 1.28 should probably just be dropped.

@fintelia fintelia merged commit b25744e into image-rs:master Nov 23, 2019
@LukasKalbertodt
Copy link

@fintelia Do you think this fix can be released with a minor version bump (i.e. 0.1.17)? That would be really great, as jpeg-decoder caused 290 other crates to regress due to this. That's the second most regression caused after colored.

@fintelia
Copy link
Contributor

fintelia commented Dec 8, 2019

@LukasKalbertodt 0.1.17 has now been published.

wartmanm pushed a commit to wartmanm/jpeg-decoder that referenced this pull request Oct 4, 2021
fix clippy::into_iter_on_array error in decoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants