Implement writing ICC profiles for JPEG and PNG images. #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
reviewed
Dec 7, 2024
alula
force-pushed
the
alula/jpeg-png-icc-profile
branch
from
675dadf to
4a08df0
Compare
|
It should be possible to implement for WebP as well, although that doesn't necessarily have to happen in this PR: https://docs.rs/image-webp/latest/image_webp/struct.WebPEncoder.html#method.set_icc_profile |
kornelski
force-pushed
the
alula/jpeg-png-icc-profile
branch
from
4a08df0 to
9128bec
Compare
|
CI should be fixed by updating the dependency in |
HeroicKatora
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
pngcrate doesn't actually write ICC profiles at all in latest published version as of writing (0.17.14), however it seems that 0.17.15 will be released soon: image-rs/image-png@10644db