[PATCH] Added offsets to SubImage to compensate for the now-deprecated bounds call from GenericImageView.

[brykgroup-andrews]

Fixes #2118

@fintelia It worked this time lol

[fintelia]

I think the offsets method makes sense on the SubImage struct, but I'm not really sure we should expose it on GenericImageView. The difference is that the GenericImageView (for immutable access) and GenericImage (for mutable access) traits should be implementable for any sort of image. For most of them, the concept of an offset from a different origin doesn't make a ton of sense.

[brykgroup-andrews]

I'm down with that, if that's more reasonable. However the reason I did it on GenericImageView is that the old interface also provided it - it allows the method to be used in the same contexts as the previous one. If you think it would be better to move it still in spite of this, I'm happy to make the change.

[brykgroup-andrews]

@fintelia Not sure if your thumbs up is saying you agree it should be as-is, or if you want me to make the change anyway. Which route do you want me to go down - implementing your initial suggestion, or keeping it as-is for the reasons I provided?

[fintelia]

Please add the method on SubImage but not on GenericImageView.

[brykgroup-andrews]

@fintelia should be good to go!