Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gif 0.13 #2117

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update to gif 0.13 #2117

merged 2 commits into from
Jan 30, 2024

Conversation

torokati44
Copy link
Contributor

To the tune of #1826.

@torokati44
Copy link
Contributor Author

torokati44 commented Jan 30, 2024

Looks like the OOM regression test now fails due to some additional checks added by one of the recent PRs of @kornelski.
Could you maybe offer some advice here please?
Should the test data be altered to pass this new check, or should a different error be expected now?
My hunch is on the former, but I'm not familiar enough with the GIF format to know exactly what to change...

@kornelski
Copy link
Contributor

The GIF has lzw code size == 0, but the minimum valid value is 2. You can change the data to this:

    let data = [
        71, 73, 70, 56, 55, 97, 0, 0, 0, 0, 0, 0, 0, 44, 255, 255, 219, 255, 172, 199, 199, 255,
        216, 255, 255, 0, 0, 48, 230, 2, 195, 195, 195, 195, 255, 239, 0,
    ];

and you will get the Limit error due to default memory limit of 50MB.

With the new gif crate version, it gave a different error as was.
@torokati44
Copy link
Contributor Author

Awesome, thank you so much!

@kornelski kornelski merged commit 25489be into image-rs:master Jan 30, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants