Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiff: Support CMYK images #2075

Merged
merged 1 commit into from
Dec 24, 2023
Merged

tiff: Support CMYK images #2075

merged 1 commit into from
Dec 24, 2023

Conversation

sophie-h
Copy link
Contributor

@sophie-h sophie-h commented Dec 18, 2023 •
edited
Loading

  • Cleanup tiff code

Closes #2074

sophie-h
sophie-h commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@sophie-h sophie-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someone give initial feedback if my plans are viable before I finish this,

src/traits.rs Outdated Show resolved Hide resolved
src/color.rs Outdated Show resolved Hide resolved
src/codecs/tiff.rs Show resolved Hide resolved
sophie-h
sophie-h commented Dec 18, 2023
View reviewed changes
src/color.rs Outdated Show resolved Hide resolved
@fintelia
Copy link
Contributor

fintelia commented Dec 18, 2023 •
edited
Loading

I'd feel better restricting this PR to just the changes in tiff.rs and maybe the addition of ExtendedColorType::Cmyk8. The read_image method could directly call a crate private cmyk_to_rgb method.

Based on posts like this, it looks like doing CMYK -> RGB conversion properly requires much sophisticated color handling than we're going to be able to support any time soon. So I'd rather not add Cmyk<T> as a new Pixel struct

fintelia
fintelia reviewed Dec 19, 2023
View reviewed changes
src/codecs/tiff.rs Outdated Show resolved Hide resolved
@fintelia fintelia merged commit 139e809 into image-rs:master Dec 24, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fintelia fintelia fintelia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support CMYK conversion (for TIFFs)
2 participants
@sophie-h @fintelia