Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly decode non-ASCII tEXt chunks and support encoding them #39

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

targos
Copy link
Member

@targos targos commented Feb 13, 2024

Refs: #26

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (395ecee) 91.54% compared to head (c645b96) 92.20%.

❗ Current head c645b96 differs from pull request most recent head 58b383c. Consider uploading reports for the commit 58b383c to get more accurate results

Files Patch % Lines
src/helpers/crc.ts 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   91.54%   92.20%   +0.65%     
==========================================
  Files           9       10       +1     
  Lines         426      462      +36     
  Branches       84       87       +3     
==========================================
+ Hits          390      426      +36     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos targos marked this pull request as draft February 13, 2024 10:58
@targos
Copy link
Member Author

targos commented Feb 13, 2024

I'm working on the encoder.

@targos
Copy link
Member Author

targos commented Feb 13, 2024

Done. I removed keyword-specific character validation because the spec says that decoders should be lenient: https://www.w3.org/TR/png/#13Text-chunk-processing

@targos targos marked this pull request as ready for review February 13, 2024 11:36
README.md Outdated Show resolved Hide resolved
Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos enabled auto-merge (rebase) February 13, 2024 12:30
@targos targos changed the title fix: correctly decode non-ASCII tEXt chunks Correctly decode non-ASCII tEXt chunks and support encoding them Feb 13, 2024
@targos targos merged commit ff545ce into main Feb 13, 2024
7 checks passed
@targos targos deleted the fix-text-decode branch February 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants