Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) BelowBar considers its own color stops refs #46 #47

Merged
merged 1 commit into from
Jul 12, 2019
Merged

(fix) BelowBar considers its own color stops refs #46 #47

merged 1 commit into from
Jul 12, 2019

Conversation

daniel-v
Copy link

@daniel-v daniel-v commented Jul 12, 2019 •
edited
Loading

This fixes an issue where BelowBar ignored gradientColorStops property and used colorStops from the bar itself. Should fix #46

@imaNNeo
Copy link
Owner

imaNNeo commented Jul 12, 2019

Thanks for contribution ;)
Cheers!

@imaNNeo imaNNeo merged commit c69e033 into imaNNeo:master Jul 12, 2019
@BaronTryBest BaronTryBest mentioned this pull request Nov 17, 2021
Closed
@shababhsiddique shababhsiddique mentioned this pull request Nov 28, 2021
Closed
@darkang3lz92 darkang3lz92 mentioned this pull request Jan 5, 2022
Open
@nastaran-mohammadi nastaran-mohammadi mentioned this pull request May 13, 2022
Closed
@sk784 sk784 mentioned this pull request Jun 9, 2022
Closed
@xuenuanxi xuenuanxi mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: BelowBarData accidentally considers BarData.colorsStop's count
2 participants
@daniel-v @imaNNeo