Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of swapAnimationDuration and swapAnimationCurve in docs #1496

Closed
wants to merge 2 commits into from

Conversation

SantiiRepair
Copy link

Update of swapAnimationDuration and swapAnimationCurve in markdown files due to current deprecation.

Update of `swapAnimationDuration` and `swapAnimationCurve` in markdown files due to current deprecation.
@imaNNeo
Copy link
Owner

imaNNeo commented Nov 24, 2023

Oh, I just realized that we updated line_chart properties by mistake (in this commit):

super.duration = const Duration(milliseconds: 150),
super.curve = Curves.linear,

Now we just need to rename it back to swapAnimationDuration and swapAnimationCurve just like other charts:

Duration swapAnimationDuration = const Duration(milliseconds: 150),
Curve swapAnimationCurve = Curves.linear,

Duration swapAnimationDuration = defaultDuration,
Curve swapAnimationCurve = Curves.linear,

@SantiiRepair
Copy link
Author

there are no conflicts with the base branch now

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c911024) 86.73% compared to head (34297a4) 86.73%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          45       45           
  Lines        3022     3022           
=======================================
  Hits         2621     2621           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imaNNeo
Copy link
Owner

imaNNeo commented Jan 10, 2024

It has conflicts again. Sorry for my delay.

@SantiiRepair
Copy link
Author

haha I won't solve anything, it took you 2 months to remember this pull request.

@imaNNeo
Copy link
Owner

imaNNeo commented Jan 22, 2024

I try my best to keep it updated and work on it, but as you might know, my time is limited just like everyone.
And keep in mind that no one hired me to work on this library and as a result, it is free for everyone.
Thanks for your effort btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants