Replased containerRenderBox.size to containerRenderBox.constraints.biggest #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaNNeo
reviewed
Nov 14, 2019
| @@ -86,7 +86,7 @@ class BarChartState extends AnimatedWidgetBaseState<BarChart> { | |||
| }, | |||
| child: CustomPaint( | |||
| key: _chartKey, | |||
| size: getDefaultSize(context), | |||
| size: chartSize, | |||
There was a problem hiding this comment.
Sorry for the delay.
Please do not change this line, we set the default size it means if it has not any size constrains, it uses this default size (It will be ignored if we provide a size for it) then let it be like before, it is working properly.
There was a problem hiding this comment.
Okey i will remove that. I cant do it in the following days. After monday
imaNNeo
reviewed
Nov 14, 2019
| @@ -91,7 +91,7 @@ class LineChartState extends AnimatedWidgetBaseState<LineChart> { | |||
| }, | |||
| child: CustomPaint( | |||
| key: _chartKey, | |||
| size: getDefaultSize(context), | |||
| size: chartSize, | |||
imaNNeo
reviewed
Nov 14, 2019
| @@ -87,7 +87,7 @@ class PieChartState extends AnimatedWidgetBaseState<PieChart> { | |||
| }, | |||
| child: CustomPaint( | |||
| key: _chartKey, | |||
| size: getDefaultSize(context), | |||
| size: chartSize, | |||
imaNNeo
changed the title
|
Helooo? |
|
Could we have this merged please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue 100.
RenderBox.size should not be used when building the layout.