Listen to normal tap on Tooltip instead of longpress #37

sukhcha-in · 2019-07-08T18:43:59Z

First of all, thank you for this amazing library <3

Please provide onTap option with some sort of MoveUpdate to show Tooltip on chart as an alternative to onLongPress

Looking forward for this library

The text was updated successfully, but these errors were encountered:

imsurajsharma · 2019-07-11T03:36:17Z

Yes, I also want the same thing. Please provide that functionality.

odonc · 2019-07-15T01:05:25Z

Would be great, I don't know if users will realise they can long press to show tip. Normal press would be better.

Mazas17 · 2019-07-24T18:44:10Z

Also please keep in mind that chart should maintain selected state on rebuild. For example, if some data point is selected and then rebuild occurs, that selection should be preserved.

imaNNeo · 2019-07-24T18:57:32Z

I think it should handle out of the chart,
I mean you can tell to the chart, which tooltip should be shown now,
then you can keep the state of selected tooltip on your side,
and it is more customizable.
@Mazas17

Mazas17 · 2019-07-25T09:21:33Z

Also sounds good

MostHated · 2019-07-25T22:01:32Z

To take this one further, I am wanting to use this on desktop. Is there a way to make it so that if a mouse is hovering over it, it shows all the time and follows the mouse as if you are holding down a press?

imaNNeo · 2019-07-25T23:16:07Z

Yes, for sure we will add the Desktop compatibility,
I just need time :),
Also, all contributions are welcome,
give it a try!
@MostHated

imaNNeo · 2019-07-26T17:53:30Z

Hi,
Unfortunately, Github started banning Iranian users while ago,
If they didn't stop their action, I can't continue on this repo,
read more it here,
If you want to prevent this unfair action, give a start on this repository and say your support by creating an issue, and spread it.
Best regards,
Iman Khoshabi

dipendra-sharma · 2019-07-31T10:51:20Z

I've done this enhancement. Replace your fl_chart.dart with attached file (Remove .txt).
fl_chart.dart.txt

odonc · 2019-07-31T10:55:43Z

Are you getting shut down?

…

On Wed, 31 Jul. 2019, 8:51 pm Dipendra Sharma, ***@***.***> wrote: Replace your fl_chart.dart with attached file (Remove .txt). fl_chart.dart.txt <https://github.com/imaNNeoFighT/fl_chart/files/3451322/fl_chart.dart.txt> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#37>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK43TTTMUURSMORI4FRVOMLQCFVCTANCNFSM4H66OOPQ> .

sukhcha-in · 2019-08-01T17:39:26Z

@dipendra-sharma Thank you, works as expected ;)

MostHated · 2019-08-01T21:37:17Z

Yes, for sure we will add the Desktop compatibility,
I just need time :),
Also, all contributions are welcome,
give it a try!
@MostHated

I am having a go at this to see what I can come up with.

I tried adding/changing this below. It works, but the position available for Listeners vs Gesture is only d.position and d.localPosition, so it kind of acts weird and some of the points jump to another spot on the graph with 3 lines when you get close to them slowly, lol.

I want to try a few things first to see if there is a way to fix the position before I do a PR.

class FlChart extends StatefulWidget {
  final BaseChart chart;
  var enableTap;
  var enablePointer;

  FlChart({
    Key key,
    @required this.chart,
    this.enableTap = true,
    this.enablePointer = true,
  }) : super(key: key) {
    if (chart == null) {
      throw Exception('chart should not be null');
    }
  }

  @override
  Widget build(BuildContext context) {
    return widget.enablePointer ? _withPointerInput() : widget.enableTap ? _widgetWithTap() : _widgetWithLongPress();
  }

  Widget _withPointerInput() {
    return Listener(
      onPointerEnter: (d) {
        _touchInputNotifier.value = FlLongPressStart(
          _globalToLocal(context, d.localPosition),
        );
      },
      onPointerHover: (d) {
        _touchInputNotifier.value = FlLongPressMoveUpdate(
          _globalToLocal(context, d.localPosition),
        );
      },
      onPointerExit: (d) {
        _touchInputNotifier.value = FlLongPressEnd(
          _globalToLocal(context, d.localPosition),
        );
      },
      child: CustomPaint(
        painter: widget.chart.painter(
          touchInputNotifier: _touchInputNotifier,
          touchResponseSink: widget.chart.getData().touchData.touchResponseSink,
        ),
      ),
    );
  }

imaNNeo · 2019-08-02T08:14:28Z

No, I will not shut down this repo, I just need some free times to improve it
@odonc

dipendra-sharma · 2019-08-02T08:21:51Z

Hi, @imaNNeoFighT Please add me in contributors. I've already done it, will create a PR. Both the features will be there Long press & Tap.

imaNNeo · 2019-08-02T08:25:46Z

You can make a PR already,
clone the project,
make a new branch,
push your changes to each branch separately (or maybe both of them in one branch),
then make a PR from your Repo branch to This Repo master branch.
@dipendra-sharma

dipendra-sharma · 2019-08-02T09:39:05Z

Yes, for sure we will add the Desktop compatibility,
I just need time :),
Also, all contributions are welcome,
give it a try!
@MostHated

I am having a go at this to see what I can come up with.

I tried adding/changing this below. It works, but the position available for Listeners vs Gesture is only d.position and d.localPosition, so it kind of acts weird and some of the points jump to another spot on the graph with 3 lines when you get close to them slowly, lol.

I want to try a few things first to see if there is a way to fix the position before I do a PR.

class FlChart extends StatefulWidget {
  final BaseChart chart;
  var enableTap;
  var enablePointer;

  FlChart({
    Key key,
    @required this.chart,
    this.enableTap = true,
    this.enablePointer = true,
  }) : super(key: key) {
    if (chart == null) {
      throw Exception('chart should not be null');
    }
  }

  @override
  Widget build(BuildContext context) {
    return widget.enablePointer ? _withPointerInput() : widget.enableTap ? _widgetWithTap() : _widgetWithLongPress();
  }

  Widget _withPointerInput() {
    return Listener(
      onPointerEnter: (d) {
        _touchInputNotifier.value = FlLongPressStart(
          _globalToLocal(context, d.localPosition),
        );
      },
      onPointerHover: (d) {
        _touchInputNotifier.value = FlLongPressMoveUpdate(
          _globalToLocal(context, d.localPosition),
        );
      },
      onPointerExit: (d) {
        _touchInputNotifier.value = FlLongPressEnd(
          _globalToLocal(context, d.localPosition),
        );
      },
      child: CustomPaint(
        painter: widget.chart.painter(
          touchInputNotifier: _touchInputNotifier,
          touchResponseSink: widget.chart.getData().touchData.touchResponseSink,
        ),
      ),
    );
  }

@MostHated Have you tested it? it is not working on iPhone 7.

dipendra-sharma · 2019-08-02T09:44:11Z

@imaNNeoFighT

Remote: Permission to imaNNeoFighT/fl_chart.git denied to dipendra-sharma. unable to access 'https://github.com/imaNNeoFighT/fl_chart.git/': The requested URL returned error: 403

imaNNeo · 2019-08-02T09:45:33Z

Sorry you have to firstly fork it in your profile,
Then clone it and...

MostHated · 2019-08-02T13:09:17Z

@MostHated Have you tested it? it is not working on iPhone 7.

I would assume that is because iPhone does not have a pointer. It uses touch/gesture. Pointer is for desktop platforms. I don't think anything with "pointer" in the event callback will work with Android or iPhone unless you attach a mouse to it.

I tested and it works for me on both go-flutter and flutter-desktop-embedded.

https://i.imgur.com/ECBG3G9.gifv

dipendra-sharma · 2019-08-05T05:42:08Z

@MostHated Pointer was not working on the iPhone device.

MostHated · 2019-08-05T15:37:05Z

Yes, did you read my explanation above? Pointer only works I believe if you are running on a platform which is using the debugDefaultTargetPlatformOverride = TargetPlatform.fuchsia; override, which would typically only be desktop platforms. If you are running Android or iPhone, you would not be using pointer.

imaNNeo · 2019-08-15T20:29:36Z

Hi, thanks all for your patience,
It is added in 0.1.6, If you had any feedback, feel free to let me know.
and also there are a lot of features to implement and pull requests are welcome.
Best regards!

jlubeck · 2020-03-30T21:33:11Z

@imaNNeoFighT was the MouseOver on desktop that was mentioned by @MostHated ever implemented?
I can't seem to find it in the code or documentation...

thanks!

imaNNeo · 2020-03-31T08:49:25Z

Hi @jlubeck
At the moment our main focus is on the Quality and Stability in the android and iOS,
even though, we will focus on web and desktop, when they are stabled in the Flutter.
Thanks for reaching me out.

imaNNeo · 2020-03-31T08:50:13Z

Also, feel free to make an issue about it,
we can follow it up there.

jlubeck · 2020-03-31T15:40:17Z

Ok, I was asking mainly because @MostHated seemed to had it working... I'll create the new ticket. Thank you

imaNNeo added the enhancement New feature or request label Jul 8, 2019

imaNNeo closed this as completed in a042674 Aug 15, 2019

jlubeck mentioned this issue Mar 31, 2020

Show tooltip on MouseOver on Web/Desktop #275

Closed

BaronTryBest mentioned this issue Nov 17, 2021

Flutter project ScatterChart Release crash on iPhone #812

Closed

shababhsiddique mentioned this issue Nov 28, 2021

Pie chart swapping data causes render box exception if animation enabled #829

Closed

darkang3lz92 mentioned this issue Jan 5, 2022

App crashing in release for Bar chart graphs after upgrading to flutter 2.8.1 #864

Open

nastaran-mohammadi mentioned this issue May 13, 2022

fl chart error when all values are 0 #1007

Closed

sk784 mentioned this issue Jun 9, 2022

Throws exception if number of points on the x-axis = 1 #1053

Closed

xuenuanxi mentioned this issue Jun 16, 2022

Offset argument contained a NaN value. Data initialization with Network request #1061

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Listen to normal tap on Tooltip instead of longpress #37

Listen to normal tap on Tooltip instead of longpress #37

sukhcha-in commented Jul 8, 2019

imsurajsharma commented Jul 11, 2019

odonc commented Jul 15, 2019 •

edited

Loading

Mazas17 commented Jul 24, 2019 •

edited

Loading

imaNNeo commented Jul 24, 2019

Mazas17 commented Jul 25, 2019

MostHated commented Jul 25, 2019

imaNNeo commented Jul 25, 2019

imaNNeo commented Jul 26, 2019

dipendra-sharma commented Jul 31, 2019 •

edited

Loading

odonc commented Jul 31, 2019 via email

sukhcha-in commented Aug 1, 2019

MostHated commented Aug 1, 2019 •

edited

Loading

imaNNeo commented Aug 2, 2019

dipendra-sharma commented Aug 2, 2019

imaNNeo commented Aug 2, 2019

dipendra-sharma commented Aug 2, 2019

dipendra-sharma commented Aug 2, 2019

imaNNeo commented Aug 2, 2019

MostHated commented Aug 2, 2019 •

edited

Loading

dipendra-sharma commented Aug 5, 2019

MostHated commented Aug 5, 2019 •

edited

Loading

imaNNeo commented Aug 15, 2019

jlubeck commented Mar 30, 2020 •

edited

Loading

imaNNeo commented Mar 31, 2020

imaNNeo commented Mar 31, 2020

jlubeck commented Mar 31, 2020

Listen to normal tap on Tooltip instead of longpress #37

Listen to normal tap on Tooltip instead of longpress #37

Comments

sukhcha-in commented Jul 8, 2019

imsurajsharma commented Jul 11, 2019

odonc commented Jul 15, 2019 • edited Loading

Mazas17 commented Jul 24, 2019 • edited Loading

imaNNeo commented Jul 24, 2019

Mazas17 commented Jul 25, 2019

MostHated commented Jul 25, 2019

imaNNeo commented Jul 25, 2019

imaNNeo commented Jul 26, 2019

dipendra-sharma commented Jul 31, 2019 • edited Loading

odonc commented Jul 31, 2019 via email

sukhcha-in commented Aug 1, 2019

MostHated commented Aug 1, 2019 • edited Loading

imaNNeo commented Aug 2, 2019

dipendra-sharma commented Aug 2, 2019

imaNNeo commented Aug 2, 2019

dipendra-sharma commented Aug 2, 2019

dipendra-sharma commented Aug 2, 2019

imaNNeo commented Aug 2, 2019

MostHated commented Aug 2, 2019 • edited Loading

dipendra-sharma commented Aug 5, 2019

MostHated commented Aug 5, 2019 • edited Loading

imaNNeo commented Aug 15, 2019

jlubeck commented Mar 30, 2020 • edited Loading

imaNNeo commented Mar 31, 2020

imaNNeo commented Mar 31, 2020

jlubeck commented Mar 31, 2020

odonc commented Jul 15, 2019 •

edited

Loading

Mazas17 commented Jul 24, 2019 •

edited

Loading

dipendra-sharma commented Jul 31, 2019 •

edited

Loading

MostHated commented Aug 1, 2019 •

edited

Loading

MostHated commented Aug 2, 2019 •

edited

Loading

MostHated commented Aug 5, 2019 •

edited

Loading

jlubeck commented Mar 30, 2020 •

edited

Loading