-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add MIT license information to update-header.sh #3174
Conversation
PR SummaryThis PR removes the Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that file shouldn't be in the repository anymore. I'll gladly accept the PR if you delete the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 0b0c205: chore: remove update-header.sh script
Files Processed (1)
- update-header.sh (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 6f96d31: Merge remote-tracking branch 'upstream/master'
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iluwatar,
I’ve updated the branch as requested and removed the update-header.sh script. All checks have passed, and the branch is up-to-date. Please let me know if there's anything else required before merging. Thank you!
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @clintaire for code |
I've put up a pull request to add @clintaire! 🎉 |
This pull request adds an MIT license header to the update-header.sh script to enhance compliance and maintain consistent attribution within the project. The license header was automatically added during a recent update to my fork.
No changes were made to the script's functionality.
I noticed that license headers were added automatically to my fork. If this aligns with the project's standards, I would be happy to submit similar changes for other files where it might be applicable.