Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add MIT license information to update-header.sh #3174

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

clintaire
Copy link
Contributor

This pull request adds an MIT license header to the update-header.sh script to enhance compliance and maintain consistent attribution within the project. The license header was automatically added during a recent update to my fork.

No changes were made to the script's functionality.

I noticed that license headers were added automatically to my fork. If this aligns with the project's standards, I would be happy to submit similar changes for other files where it might be applicable.

Copy link

github-actions bot commented Jan 12, 2025

PR Summary

This PR removes the update-header.sh script, which previously updated headers in README.md files. The script's removal simplifies the project and eliminates the need for its maintenance.

Changes

File Summary
update-header.sh The update-header.sh script, used to update headers in README.md files, has been removed. This change simplifies the project and removes the need for maintaining the script.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (2)
  • bf77e0b: Merge branch 'iluwatar:master' into master
  • dd9b0d0: chore: add MIT license information to update-header.sh
Files Processed (1)
  • update-header.sh (1 hunk)
Actionable Comments (0)
Skipped Comments (0)

@iluwatar
Copy link
Owner

Actually that file shouldn't be in the repository anymore. I'll gladly accept the PR if you delete the file.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 0b0c205: chore: remove update-header.sh script
Files Processed (1)
  • update-header.sh (1 hunk)
Actionable Comments (0)
Skipped Comments (0)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 6f96d31: Merge remote-tracking branch 'upstream/master'
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)

Copy link
Contributor Author

@clintaire clintaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iluwatar,
I’ve updated the branch as requested and removed the update-header.sh script. All checks have passed, and the branch is up-to-date. Please let me know if there's anything else required before merging. Thank you!

@iluwatar iluwatar merged commit 2a261cd into iluwatar:master Jan 13, 2025
2 checks passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @clintaire for code

Copy link
Contributor

@iluwatar

I've put up a pull request to add @clintaire! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants