Minor misspelling #3161
Minor misspelling #3161
Conversation
PR SummaryThis PR fixes a misspelling in the documentation and code examples related to the Strategy design pattern. The corrected phrase is now "With your Excalibur you sever the dragon's head!" instead of the previous misspelling. The change affects multiple language localizations (es, ko) and the main codebase. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (2)
Files Processed (1)
- strategy/README.md (2 hunks)
Actionable Comments (1)
-
strategy/README.md [130-130]
typo: "Correct spelling of 'sever'"
Skipped Comments (1)
-
strategy/README.md [165-171]
consistency: "Consistent use of 'sever' in log messages"
| @@ -127,7 +127,7 @@ public class App { | |||
| // Java 8 functional implementation Strategy pattern | |||
| LOGGER.info(GREEN_DRAGON_SPOTTED); | |||
| dragonSlayer = new DragonSlayer( | |||
| () -> LOGGER.info("With your Excalibur you severe the dragon's head!")); | |||
| () -> LOGGER.info("With your Excalibur you sever the dragon's head!")); | |||
There was a problem hiding this comment.
The word "sever" is used correctly in this context, referring to cutting or separating something. The previous spelling, "severe", means extremely bad or serious. The change is accurate and improves clarity.
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (2)
- f9bb8a1: Merge branch 'patch-1' of https://github.com/mehdirahimi/java-design-patterns into patch-1
- ca60505: Merge branch 'iluwatar:master' into patch-1
Files Processed (4)
- localization/es/strategy/README.md (1 hunk)
- localization/ko/strategy/README.md (1 hunk)
- strategy/src/main/java/com/iluwatar/strategy/App.java (1 hunk)
- strategy/src/main/java/com/iluwatar/strategy/LambdaStrategy.java (1 hunk)
Actionable Comments (4)
-
localization/es/strategy/README.md [130-130]
typo: "Fix misspelling of "severe""
-
localization/ko/strategy/README.md [126-126]
typo: "Fix misspelling of "severe""
-
strategy/src/main/java/com/iluwatar/strategy/App.java [69-69]
typo: "Fix misspelling of "severe""
-
strategy/src/main/java/com/iluwatar/strategy/LambdaStrategy.java [40-40]
typo: "Fix misspelling of "severe""
Skipped Comments (0)
| @@ -127,7 +127,7 @@ public class LambdaStrategy { | |||
|
|
|||
| public enum Strategy implements DragonSlayingStrategy { | |||
| MeleeStrategy(() -> LOGGER.info( | |||
| "With your Excalibur you severe the dragon's head!")), | |||
| "With your Excalibur you sever the dragon's head!")), | |||
There was a problem hiding this comment.
The word "severe" was misspelled as "sever" in multiple files. This commit corrects the misspelling to ensure consistency and accuracy.
| @@ -123,7 +123,7 @@ public class LambdaStrategy { | |||
|
|
|||
| public enum Strategy implements DragonSlayingStrategy { | |||
| MeleeStrategy(() -> LOGGER.info( | |||
| "With your Excalibur you severe the dragon's head!")), | |||
| "With your Excalibur you sever the dragon's head!")), | |||
There was a problem hiding this comment.
The word "severe" was misspelled as "sever" in multiple files. This commit corrects the misspelling to ensure consistency and accuracy.
| @@ -66,7 +66,7 @@ public static void main(String[] args) { | |||
| // Java 8 functional implementation Strategy pattern | |||
| LOGGER.info(GREEN_DRAGON_SPOTTED); | |||
| dragonSlayer = new DragonSlayer( | |||
| () -> LOGGER.info("With your Excalibur you severe the dragon's head!")); | |||
| () -> LOGGER.info("With your Excalibur you sever the dragon's head!")); | |||
There was a problem hiding this comment.
The word "severe" was misspelled as "sever". This commit corrects the misspelling to ensure consistency and accuracy.
| @@ -37,7 +37,7 @@ public class LambdaStrategy { | |||
| */ | |||
| public enum Strategy implements DragonSlayingStrategy { | |||
| MELEE_STRATEGY(() -> LOGGER.info( | |||
| "With your Excalibur you severe the dragon's head!")), | |||
| "With your Excalibur you sever the dragon's head!")), | |||
There was a problem hiding this comment.
The word "severe" was misspelled as "sever". This commit corrects the misspelling to ensure consistency and accuracy.
|
Changes applied to source code files. |
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @mehdirahimi for code |
|
I've put up a pull request to add @mehdirahimi! 🎉 |
No description provided.