fix: bug where no-sandbox is required (#72)

- always use no-sandbox flag on puppeteer Closes: #69
iloveitaly · Dec 9, 2024 · 11d071a · 11d071a
1 parent e70b8a8
commit 11d071a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/index.ts b/index.ts
@@ -28,9 +28,12 @@ async function getBrowser() {
     ],
   };
 
+  // always use no sandbox
+  // should be safe since only 3 known domains are accessed
+  // required for docker and pi deployments and anyone that wants to use as root
+  puppeteerOpts.args!.push("--no-sandbox");
   if (isPi()) {
     puppeteerOpts.executablePath = "/usr/bin/chromium";
-    puppeteerOpts.args!.push("--no-sandbox");
   } else {
     // https://stackoverflow.com/questions/74251875/puppeteer-error-an-executablepath-or-channel-must-be-specified-for-puppete
     puppeteerOpts.executablePath = executablePath();