Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored components files #8

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Refactored components files #8

merged 6 commits into from
Dec 5, 2024

Conversation

ilong4rennes
Copy link
Owner

@ilong4rennes ilong4rennes commented Dec 3, 2024 •
edited
Loading

What?

  • Refactored from class components to function components

Testing

ESLint

  • Process /bin/sh -c npm run eslint passes during make test

Manual Testing in the UI

  • admin/src/app.jsx:165
    • the starting point of the react app, everything works as before.
  • admin/src/Components/CheckboxInput.jsx:4
image
  • admin/src/Components/DatePeriodInput.js:5
  • admin/src/Components/DateTimeInput.jsx:5
image
  • admin/src/Components/Login.jsx:6
image
  • admin/src/Components/MemberForm.js:7
image

@ilong4rennes ilong4rennes self-assigned this Dec 3, 2024
@ilong4rennes ilong4rennes changed the title Refactored date related files Refactored components files Dec 3, 2024
@shantinghou
Copy link
Collaborator

LGTM!

@shantinghou shantinghou merged commit 9435fa9 into main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shantinghou shantinghou Awaiting requested review from shantinghou

@guanjiecheng guanjiecheng Awaiting requested review from guanjiecheng

@sofiareyesf sofiareyesf Awaiting requested review from sofiareyesf

Assignees

@ilong4rennes ilong4rennes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilong4rennes @shantinghou