Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored the 'preventDefault' error, and removed comments #35

Merged
merged 3 commits into from
Dec 13, 2024
Merged

refactored the 'preventDefault' error, and removed comments #35

merged 3 commits into from
Dec 13, 2024

Conversation

ilong4rennes
Copy link
Owner

@ilong4rennes ilong4rennes commented Dec 13, 2024 •
edited
Loading

According to the comments,

  • deleted comments and unused hooks
  • changed from e.preventDefault(); to return false;
  • turned into controlled component in RequestPasswordReset.jsx
  • removed withRouter in admin/src/Membership/KeyEdit.jsx

@ilong4rennes ilong4rennes self-assigned this Dec 13, 2024
@ilong4rennes ilong4rennes merged commit f82d9d8 into main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shantinghou shantinghou Awaiting requested review from shantinghou

@guanjiecheng guanjiecheng Awaiting requested review from guanjiecheng

@sofiareyesf sofiareyesf Awaiting requested review from sofiareyesf

Assignees

@ilong4rennes ilong4rennes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilong4rennes