Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix membership group lint #20

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix membership group lint #20

merged 1 commit into from
Dec 5, 2024

Conversation

shantinghou
Copy link
Collaborator

@shantinghou shantinghou commented Dec 5, 2024

Membership group did not work after fixing lint error. Seemed like it works properly but ESLint notifies a false positive error so we just reverted the changes and added an ignore line.

Screenshot 2024-12-05 at 4 42 10 PM

@shantinghou shantinghou added the bug Something isn't working label Dec 5, 2024
@shantinghou shantinghou self-assigned this Dec 5, 2024
Copy link
Collaborator

@guanjiecheng guanjiecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shantinghou shantinghou merged commit 9836d0a into main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants