Skip to content

Commit

Permalink
Fix for ascii equivalent for greek letter theta
Browse files Browse the repository at this point in the history
This is a fix for the Greek letter Theta (https://en.wikipedia.org/wiki/Theta) which is now replaced by O which is completely irrelevant.
I believe this was a mistake in the original code due to the cyrilic ө (https://en.wiktionary.org/wiki/%D3%A8) which is correctly replaced by ο (it is left untouched in my proposal).

I have also created a PR to the original source danielstjules/Stringy#193 but the project seems abandonded. However my changes were copied on a better mantained fork https://github.com/voku/Stringy

P.S. I am a Greek native speaker
  • Loading branch information
nikosv authored Jun 30, 2019
1 parent a23e0b4 commit 5d32b30
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Str.php
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ protected static function charsArray()
'l' => ['ł', 'ľ', 'ĺ', 'ļ', 'ŀ', 'л', 'λ', 'ل', '', '', ''],
'm' => ['м', 'μ', 'م', '', '', ''],
'n' => ['ñ', 'ń', 'ň', 'ņ', 'ʼn', 'ŋ', 'ν', 'н', 'ن', '', '', ''],
'o' => ['ó', 'ò', '', 'õ', '', 'ô', '', '', '', '', '', 'ơ', '', '', '', '', '', 'ø', 'ō', 'ő', 'ŏ', 'ο', '', '', '', '', '', '', '', 'ό', 'о', 'و', 'θ', 'ို', 'ǒ', 'ǿ', 'º', '', '', '', 'ö'],
'o' => ['ó', 'ò', '', 'õ', '', 'ô', '', '', '', '', '', 'ơ', '', '', '', '', '', 'ø', 'ō', 'ő', 'ŏ', 'ο', '', '', '', '', '', '', '', 'ό', 'о', 'و', 'ို', 'ǒ', 'ǿ', 'º', '', '', '', 'ö'],
'p' => ['п', 'π', '', '', 'پ', ''],
'q' => ['', ''],
'r' => ['ŕ', 'ř', 'ŗ', 'р', 'ρ', 'ر', '', ''],
Expand Down Expand Up @@ -665,7 +665,7 @@ protected static function charsArray()
'shch' => ['щ'],
'ss' => ['ß'],
'sx' => ['ŝ'],
'th' => ['þ', 'ϑ', 'ث', 'ذ', 'ظ'],
'th' => ['þ', 'ϑ', 'θ', 'ث', 'ذ', 'ظ'],
'ts' => ['ц', '', ''],
'ue' => ['ü'],
'uu' => [''],
Expand All @@ -687,7 +687,7 @@ protected static function charsArray()
'L' => ['Ĺ', 'Ł', 'Л', 'Λ', 'Ļ', 'Ľ', 'Ŀ', '', ''],
'M' => ['М', 'Μ', ''],
'N' => ['Ń', 'Ñ', 'Ň', 'Ņ', 'Ŋ', 'Н', 'Ν', ''],
'O' => ['Ó', 'Ò', '', 'Õ', '', 'Ô', '', '', '', '', '', 'Ơ', '', '', '', '', '', 'Ø', 'Ō', 'Ő', 'Ŏ', 'Ο', 'Ό', '', '', '', '', '', '', '', 'Ό', 'О', 'Θ', 'Ө', 'Ǒ', 'Ǿ', '', 'Ö'],
'O' => ['Ó', 'Ò', '', 'Õ', '', 'Ô', '', '', '', '', '', 'Ơ', '', '', '', '', '', 'Ø', 'Ō', 'Ő', 'Ŏ', 'Ο', 'Ό', '', '', '', '', '', '', '', 'Ό', 'О', 'Ө', 'Ǒ', 'Ǿ', '', 'Ö'],
'P' => ['П', 'Π', ''],
'Q' => [''],
'R' => ['Ř', 'Ŕ', 'Р', 'Ρ', 'Ŗ', ''],
Expand Down Expand Up @@ -715,7 +715,7 @@ protected static function charsArray()
'Sh' => ['Ш'],
'Shch' => ['Щ'],
'Ss' => [''],
'Th' => ['Þ'],
'Th' => ['Þ', 'Θ'],
'Ts' => ['Ц'],
'Ya' => ['Я'],
'Yu' => ['Ю'],
Expand Down

0 comments on commit 5d32b30

Please sign in to comment.