Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugging for new socket error #258

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Conversation

nwalters512
Copy link
Contributor

We're now seeing a fun new variety of error relating to setting up sockets:

Unhandled rejection (promise:  Promise {
 <rejected> TypeError: Cannot destructure property `courseId` of 'undefined' or 'null'.
   at Socket.socket.on (/home/waf/queue/build/socket/server.js:233:46)
   at <anonymous> } , reason:  TypeError: Cannot destructure property `courseId` of 'undefined' or 'null'.
   at Socket.socket.on (/home/waf/queue/build/socket/server.js:233:46)
   at <anonymous> ).

This PR adds explicit logging for when that fails to hopefully help trace the problem back to its source.

@vercel
Copy link

vercel bot commented Apr 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@nwalters512 nwalters512 merged commit 4994b2e into master Apr 3, 2019
@nwalters512 nwalters512 deleted the debugging-socket-error branch April 3, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants