Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard->calendar scrolly fixxy #8141

Conversation

michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick commented Sep 17, 2024

Somewhat fixes ilios/ilios#5716

This PR does two things: 1) it removes an unnecessary {did-insert}, and 2) it moves the Dashboard->Calendar window scroll up a bit so the top of the viewport sits just above the filter headers, instead of hiding them.

@michaelchadwick michaelchadwick changed the title Frontend 5716 calendar scrolly fixxy calendar scrolly fixxy Sep 17, 2024
@michaelchadwick michaelchadwick changed the title calendar scrolly fixxy dashboard->calendar scrolly fixxy Sep 17, 2024
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this as an interim solution. I'd rather see no scroll at all when clicking, but at least I can see the headers for the filters now.

Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an improvement I'll give this PR that - enough to approve it for sure.

@michaelchadwick michaelchadwick merged commit 7b7aebb into ilios:master Sep 19, 2024
43 of 47 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5716-calendar-scrolly-fixxy branch September 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement Suggestion - Activate Filters On Calendar - No Auto-scroll if Possible
3 participants