Skip to content

Commit

Permalink
fix: correct gitlab type references (#125)
Browse files Browse the repository at this point in the history
  • Loading branch information
sspans-sbp authored Oct 21, 2024
1 parent 14146af commit d5be9bd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ The current authentication model requires providing Vault with a Gitlab Token.
| base_url | yes | n/a | no | The address to access Gitlab |
| auto_rotate_token | no | no | no | Should we autorotate the token when it's close to expiry? (Experimental) |
| auto_rotate_before | no | 24h | no | How much time should be remaining on the token validity before we should rotate it? Minimum can be set to 24h and maximum to 730h |
| type | yes | n/a | no | The type of gitlab instance that we use can be one of saas, self-hosted or dedicated |
| type | yes | n/a | no | The type of gitlab instance that we use can be one of saas, self-managed or dedicated |
### Role
Expand Down
4 changes: 2 additions & 2 deletions path_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var (
DisplayAttrs: &framework.DisplayAttributes{
Name: "GitLab Base URL",
},
Description: `The base URL of your GitLab instance. This could be the URL of a self-hosted GitLab instance or the URL of the GitLab SaaS service (https://gitlab.com). The URL must be properly formatted, including the scheme (http or https). This field is essential as it determines the endpoint where API requests will be directed.`,
Description: `The base URL of your GitLab instance. This could be the URL of a self-managed GitLab instance or the URL of the GitLab SaaS service (https://gitlab.com). The URL must be properly formatted, including the scheme (http or https). This field is essential as it determines the endpoint where API requests will be directed.`,
},
"type": {
Type: framework.TypeString,
Expand All @@ -43,7 +43,7 @@ var (
TypeSaaS,
TypeDedicated,
},
Description: `The type of GitLab instance you are connecting to. This could typically distinguish between 'self-hosted' for on-premises GitLab installations or 'saas' or 'dedicated' for the GitLab SaaS offering. This field helps the plugin to adjust any necessary configurations or request patterns specific to the type of GitLab instance.`,
Description: `The type of GitLab instance you are connecting to. This could typically distinguish between 'self-managed' for on-premises GitLab installations or 'saas' or 'dedicated' for the GitLab SaaS offering. This field helps the plugin to adjust any necessary configurations or request patterns specific to the type of GitLab instance.`,
DisplayAttrs: &framework.DisplayAttributes{
Name: "GitLab Type",
},
Expand Down

0 comments on commit d5be9bd

Please sign in to comment.