No longer compiles with GNOME 3.28 gweather library

[fossfreedom]

ubuntu budgie 18.04

https://launchpadlibrarian.net/360636309/buildlog_ubuntu-bionic-i386.budgie-weather-applet_0.1-0ubuntu2~bionic+build3_BUILDING.txt.gz

the relevant part is

[4/12] valac -C --debug --pkg gweather-3.0 --pkg libsoup-2.4 --pkg json-glib-1.0 --pkg budgie-1.0 --pkg libpeas-1.0 --target-glib ' 2.46.0' --pkg glib-2.0 --pkg gtk+-3.0 --color=always --directory src/budgieweatherapplet@sha --basedir ../src --library budgieweatherapplet --header src/budgieweatherapplet.h --vapi ../budgieweatherapplet.vapi --gresources=/<<PKGBUILDDIR>>/src/plugin.gresource.xml ../src/BudgieWeatherApplet.vala ../src/Providers/OpenWeatherMap.vala ../src/Providers/LibGWeather.vala ../src/Providers/Common.vala ../src/WeatherInfo.vala ../src/ILogindManager.vala
FAILED: src/budgieweatherapplet@sha/BudgieWeatherApplet.c src/budgieweatherapplet@sha/Providers/OpenWeatherMap.c src/budgieweatherapplet@sha/Providers/LibGWeather.c src/budgieweatherapplet@sha/Providers/Common.c src/budgieweatherapplet@sha/WeatherInfo.c src/budgieweatherapplet@sha/ILogindManager.c src/budgieweatherapplet.h src/budgieweatherapplet.vapi 
valac -C --debug --pkg gweather-3.0 --pkg libsoup-2.4 --pkg json-glib-1.0 --pkg budgie-1.0 --pkg libpeas-1.0 --target-glib ' 2.46.0' --pkg glib-2.0 --pkg gtk+-3.0 --color=always --directory src/budgieweatherapplet@sha --basedir ../src --library budgieweatherapplet --header src/budgieweatherapplet.h --vapi ../budgieweatherapplet.vapi --gresources=/<<PKGBUILDDIR>>/src/plugin.gresource.xml ../src/BudgieWeatherApplet.vala ../src/Providers/OpenWeatherMap.vala ../src/Providers/LibGWeather.vala ../src/Providers/Common.vala ../src/WeatherInfo.vala ../src/ILogindManager.vala
../src/Providers/LibGWeather.vala:8.62-8.82: error: The name `ForecastType' does not exist in the context of `GWeather'
        GWeather.Info gweather_info = new GWeather.Info(loc, GWeather.ForecastType.STATE);
                                                             ^^^^^^^^^^^^^^^^^^^^^
../src/Providers/LibGWeather.vala:8.39-8.89: error: 1 extra arguments for `void GWeather.Info.new (GWeather.Location?)'
        GWeather.Info gweather_info = new GWeather.Info(loc, GWeather.ForecastType.STATE);
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is built against libgweather-3-15

According to this https://lazka.github.io/pgi-docs/#GWeather-3.0/classes/Info.html#GWeather.Info.new the forecasttype parameter is deprecated and ignored so looks like it can safely be removed in the code.

[fossfreedom]

ok - removing that obsolete param allows the compilation to complete.

It installs correctly.

However, changing the location is very odd. For gweather, I can select a location and hit the update button and the weather updates. If immediately then change the location again and hit update the weather doesn't change.

But if I then restart the panel the weather is correctly found from the new location. Any ideas why this occurs?

[ilgarmehmetali]

Removing that param means axing support for older versions, so we should bump the version number for meson too;

budgie-weather-applet/meson.build

Line 39 in 210d3c3

dep_gweather = dependency('gweather-3.0', version: '>= 3.18')

Location problem need some debugging. Some gsetting stuff i wrote might have been at fault.