Fix "reset": also reset module alias names #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on some tests I had weird issues: tests started failing when I added a describe block.
Several things where happening:
when module-alias package is nested (looking up __dirname/../../)
. Each of these modules registers their own handlers, and have to be reset separately.As part of this PR, I also cleaned up the tests:
Custom handler function
describe block within the test suite: it reference the "moduleAlias" variable which is initialized by the "before" block. Also moved "moduleAlias" within the top-level describe. We could have imported it directly above the describe, but since it's the thing under test, that looks more explicit to me.