AES Encryption Reorganization #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments. Move polyfill implementations into one class with calls to real implementations to clean up call sites. Remove some inheritence. Seemed to be useful to reference static properties from the base class. But ultimately these are all just static classes. Revert from file-scoped namespaces. I like these, but the whole project doens't use them. Better to keep it consistent for now.
AliveDevil
reviewed
Jan 17, 2025
AliveDevil
reviewed
Jan 17, 2025
AliveDevil
reviewed
Jan 17, 2025
AliveDevil
reviewed
Jan 17, 2025
AliveDevil
reviewed
Jan 17, 2025
src/IKVM.Runtime/Util/Com/Sun/Crypto/Provider/CipherBlockChaining.cs
Outdated
Show resolved
Hide resolved
AliveDevil
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move polyfill implementations into one class with calls to real implementations to clean up call sites.
Remove some inheritence. Seemed to be useful to reference static properties from the base class. But ultimately these are all just static classes.
Revert from file-scoped namespaces. I like these, but the whole project doens't use them. Better to keep it consistent for now.