-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static compiler-flag #562
Conversation
My only hesitation at this point is around the name of the MSBuild property: CompileStatically doesn't strike me as correct. |
How about |
Is just |
Could be, but just "Static" for me isn't a descriptive property. Suggesting |
What do you mean importing IKVM? You mean IKVM reference? That doesn't use global properties. |
Ah, didn't know that. Thought that the IkvmReference would also use the IKVM.NET.Sdk-stuff for invoking ikvmc. |
The IkvmCompiler and IkvmExporter task are shared, but that's about it. I like the more verbose name better (DisableDynamicTypeResolution). I tried to think it through. Problem is, -static itself is sort of a hack right now on ikvmc.... and includes more than just dynamic type lookup. But also a codegen option to disable refemit in various circumstances. It's not exactly strictly defined as to what 'static' means here. And I can imagine us adding more options here too: NAOT scenarios might want to limit certain things, but allow other things. I don't like it as an option at all on ikvmc. But, it's there. And it's going to have to stay. I figure if "Static" doesn't overlap with any javac options (and it doesn't). And we can add a similar "Static" metadata value to IkvmReference.... that's probably fine. For now. |
Ack. |
7a1be54
to
34da447
Compare
|
No description provided.