-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft discussion #1
Conversation
Right now, this pretty much just represents my understanding of how Nebula royalties work with CIP68. There's a couple ideas I may want to add / propose, such as introducing asset-specific royalties. I haven't gotten to fleshing those out in my head yet though. If you guys have other ideas you'd like to propose, please include them here for discussion. I will drop my ideas here as well once I get my head around them. |
Fixed the token name to match nebula implementation since I hadn't meant to depart from it. I do have something of an issue with the way the nebula implementation tethers royalties to collections, but I think that's likely better addressed with a more robust datum structure than by allowing multiple royalty data. Still mulling this idea over. |
Regarding the above ^ we decided against departing from the most basic implementation. We intend to first push a simple, forward compatible base for royalty information to ensure it passes the CIP process, and then follow with improvements such as multiple royalties which may be more controversial. |
A couple realizations from my review today: 1: In the current implementation & specification designed by Ales for Nebula, neither to policyId nor the tokenName of the Solutions I've come up with are:
I lean toward the former, but that would break some of the Nebula royalty NFTs that have already been minted. I expect Ales had some solution in mind for lookups, but want to get your feedback before I ask him. @colll78 @solidsnakedev 2: Although it isn't specified anywhere yet, I wonder if we may have more luck passing this solution if we specify some limitation on validation rules for the script the I'm leaning away from this for our first/second drafts; I figure we can introduce that if people request it in the public review, but again interested in your input. |
My understanding when reading our Onchain solutions is that , we mint 3 tokens with the same Minting Policy ID
I think It's possible to find the royalty info if we do the follwing:
IMO Nebula solution is far away from what we're proposing, since Ales made it so that it only works with his marketPlace contract, and we might as well consider using a different royalty label. |
I went ahead and made the policyId match required. Since there are a lot of possible valid designs for royalty control, I left out specifying it at all. I believe this should be ready to pass on to Ales / Nick etc. for their thoughts. |
Closing. Will create a second draft PR so we have a clean slate as we gather collaborator input. |
* Add a draft for Query Layer Standardization * added PR number to discussions Co-authored-by: Ryan Williams <[email protected]> * Apply suggestions from code review * Expand use cases and ecosystem risks * assign CIP number 113 * accidentally promoted as CIP instead of CPS * Update CPS-0012 directory name * removing artefact HTML comment from CPS template * removing invalid YAML for formatted Discord reference * more + deeper links to Discord discussions * add feedback from workshop 1 replacing PR #1 * Update CPS-0012/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * fix typo Co-authored-by: Vladimir Kalnitsky <[email protected]> * Apply suggestions from code review * add adoption barriers and open new open question * Apply suggestions from code review Fix phrasing Co-authored-by: Ryan <[email protected]> * Apply suggestions from code review Co-authored-by: Ryan <[email protected]> --------- Co-authored-by: Robert Phair <[email protected]> Co-authored-by: Ryan Williams <[email protected]> Co-authored-by: Ryan Williams <[email protected]>
NOTE: This PR will remain as a draft and be closed once a second draft is finalized. The actual merge from this branch into master will be done in the CF Cips repo, after third draft is finalized.